Skip to content

Bump fedora-coreos-config#1300

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreosbot-releng:fcc-sync
Jun 2, 2023
Merged

Bump fedora-coreos-config#1300
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
coreosbot-releng:fcc-sync

Conversation

@coreosbot-releng
Copy link
Copy Markdown

@coreosbot-releng coreosbot-releng commented May 28, 2023 •
edited
Loading

Created by GitHub workflow (source).

Dusty Mabe (5):
      overlay.d/05core: drop nmstate.service in preset file
      manifests/fedora-coreos-base: drop dracut nvmf workaround
      manifests: enable OSTree autopruning for ppc64le
      manifests: enable autoprune, re-add qcom dtbs on aarch64 in F39+
      overrides: fast-track ostree-2023.3-2.fc38

Huijing Hei (1):
      tests: add test `nvme-symlink` to verify GCP udev rules

Jonathan Lebon (1):
      tests/kola: upstream network-online login test from RHCOS

@openshift-ci openshift-ci Bot requested review from ashcrow and c4rt0 May 28, 2023 00:03
@jlebon
Copy link
Copy Markdown
Member

jlebon commented May 28, 2023

/retest

2 similar comments
@c4rt0
Copy link
Copy Markdown
Contributor

c4rt0 commented May 28, 2023

/retest

@c4rt0
Copy link
Copy Markdown
Contributor

c4rt0 commented May 29, 2023

/retest

@jlebon
Copy link
Copy Markdown
Member

jlebon commented May 29, 2023

I rebased this to pick up #1294 and included a commit to remove the test added there as per #1294 (comment).

@coreosbot-releng coreosbot-releng force-pushed the fcc-sync branch 2 times, most recently from 09a1127 to a36b952 Compare May 31, 2023 00:02
@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented May 31, 2023

I rebased this to pick up #1294 and included a commit to remove the test added there as per #1294 (comment).

Re-added the commit that @jlebon had added before. Hopefully this merges before the sync happens again.

@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented May 31, 2023

/lgtm

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 31, 2023
c4rt0
c4rt0 approved these changes May 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 31, 2023

/retest-required

Remaining retests: 0 against base HEAD a321ec6 and 2 for PR HEAD 21b271d in total

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@c4rt0
Copy link
Copy Markdown
Contributor

c4rt0 commented Jun 1, 2023

/retest

@c4rt0
Copy link
Copy Markdown
Contributor

c4rt0 commented Jun 1, 2023

LGTM

@travier
Copy link
Copy Markdown
Member

travier commented Jun 1, 2023

We'll have to re-add 20b15c6 to this one

@travier travier mentioned this pull request Jun 1, 2023
Merged
@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented Jun 1, 2023

We'll have to re-add 20b15c6 to this one

Done

@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented Jun 1, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@coreosbot
Bump fedora-coreos-config
2cc82a4 
Dusty Mabe (5):
      overlay.d/05core: drop nmstate.service in preset file
      manifests/fedora-coreos-base: drop dracut nvmf workaround
      manifests: enable OSTree autopruning for ppc64le
      manifests: enable autoprune, re-add qcom dtbs on aarch64 in F39+
      overrides: fast-track ostree-2023.3-2.fc38

Huijing Hei (1):
      tests: add test `nvme-symlink` to verify GCP udev rules

Jonathan Lebon (1):
      tests/kola: upstream network-online login test from RHCOS
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2023

@coreosbot-releng: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jmarrero
jmarrero approved these changes Jun 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, coreosbot-releng, dustymabe, jmarrero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [c4rt0,dustymabe,jmarrero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f65d06a into openshift:master Jun 2, 2023
@dustymabe dustymabe mentioned this pull request Jun 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

2 more reviewers

@jmarrero jmarrero jmarrero approved these changes

@c4rt0 c4rt0 c4rt0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmarrero jmarrero

@dustymabe dustymabe

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@coreosbot-releng @jlebon @c4rt0 @dustymabe @openshift-ci-robot @travier @jmarrero @openshift-merge-robot @coreosbot