Skip to content

[release-4.16] c9s.repo: Use okd-4.16 yum repo#1524

Closed
LorbusChris wants to merge 1 commit intoopenshift:release-4.16from
LorbusChris:okd-4.16
Closed

[release-4.16] c9s.repo: Use okd-4.16 yum repo#1524
LorbusChris wants to merge 1 commit intoopenshift:release-4.16from
LorbusChris:okd-4.16

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

This is required for outside-of-Prow SCOS composes

@openshift-ci openshift-ci Bot requested review from jmarrero and prestist June 10, 2024 11:19
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jun 10, 2024

/retest
/approve
/lgtm
/label backport-risk-assessed

Do you have a Jira ticket already for this? If yes, might as well use it. If not, I'm OK to override it.

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 10, 2024
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@travier
Copy link
Copy Markdown
Member

travier commented Jun 10, 2024

Ideally we don't do backports for C9S. Can't this be fixed somewhere else in the pipeline?

@travier
Copy link
Copy Markdown
Member

travier commented Jun 10, 2024

We also need to remove the C9S jobs for this branch.

@travier
Copy link
Copy Markdown
Member

travier commented Jun 10, 2024

openshift/release#53014

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 21, 2024

@LorbusChris: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@travier
Copy link
Copy Markdown
Member

travier commented Jun 21, 2024

/hold
As I said, we don't want to maintain C9S in branches. SCOS builds should only ever happen from the master branch.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2024
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jun 21, 2024

Let's close this based on discussions in openshift/release#53014.

/close

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 21, 2024

@jlebon: Closed this PR.

Details

In response to this:

Let's close this based on discussions in openshift/release#53014.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants