Skip to content

NO-JIRA: manifest-rhel-9.6: add early kernel repo#1741

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
jlebon:pr/early-kernel
Feb 7, 2025
Merged

NO-JIRA: manifest-rhel-9.6: add early kernel repo#1741
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
jlebon:pr/early-kernel

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Feb 6, 2025

We need to enable the rhel-9.6-early-kernel repo to ensure that we still get access to the early kernels. Non-el-only variants (like ocp-rhel-9.6) get this already through their plashets.

(In fact, the rhel-9.6-early-kernel repo is just an OCP plashet in disguise; there are excludes added so that only the kernel is permitted. This doesn't break the "el-only" concept because those kernels are RHEL-versioned. It's just that historically we've consumed them through OCP plashets, but ideally in the future we'd have a separate, clearly RHEL-versioned, repo for them... But ideally ideally, when we rebase to rhel-bootc, we have a rhel-bootc stream that uses those kernels that we would derive from.)

We need to enable the `rhel-9.6-early-kernel` repo to ensure that
we still get access to the early kernels. Non-el-only variants (like
`ocp-rhel-9.6`) get this already through their plashets.

(In fact, the `rhel-9.6-early-kernel` repo is just an OCP plashet in
disguise; there are excludes added so that only the kernel is permitted.
This doesn't break the "el-only" concept because those kernels _are_
RHEL-versioned. It's just that historically we've consumed them through
OCP plashets, but ideally in the future we'd have a separate, clearly
RHEL-versioned, repo for them... But ideally ideally, when we rebase to
rhel-bootc, we have a rhel-bootc stream that uses those kernels that we
would derive from.)
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Feb 6, 2025

CI will need openshift/release#61361.

This would've been cleaner probably as an rpm-ostree repo-packages-like feature. Though OTOH, the low-tech approach of using excludes is appealing and more universal (e.g. dnf can also use this).

Copy link
Copy Markdown
Contributor

@aaradhak aaradhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Feb 7, 2025

CI should pass now.

/retest

@aaradhak
Copy link
Copy Markdown
Contributor

aaradhak commented Feb 7, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon jlebon changed the title manifest-rhel-9.6: add early kernel repo NO-JIRA: manifest-rhel-9.6: add early kernel repo Feb 7, 2025
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Feb 7, 2025

Just going to force this in. The extensions container is hitting the same issue as openshift/release#61040 (comment). But we're doing this to fix the RHCOS pipeline in the first place.

/override ci/prow/e2e-aws
/override ci/prow/images
/label acknowledge-critical-fixes-only

@openshift-ci-robot
Copy link
Copy Markdown

@jlebon: This pull request explicitly references no jira issue.

Details

In response to this:

We need to enable the rhel-9.6-early-kernel repo to ensure that we still get access to the early kernels. Non-el-only variants (like ocp-rhel-9.6) get this already through their plashets.

(In fact, the rhel-9.6-early-kernel repo is just an OCP plashet in disguise; there are excludes added so that only the kernel is permitted. This doesn't break the "el-only" concept because those kernels are RHEL-versioned. It's just that historically we've consumed them through OCP plashets, but ideally in the future we'd have a separate, clearly RHEL-versioned, repo for them... But ideally ideally, when we rebase to rhel-bootc, we have a rhel-bootc stream that uses those kernels that we would derive from.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2025
@openshift-ci openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 7, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 7, 2025

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/e2e-aws, ci/prow/images

Details

In response to this:

Just going to force this in. The extensions container is hitting the same issue as openshift/release#61040 (comment). But we're doing this to fix the RHCOS pipeline in the first place.

/override ci/prow/e2e-aws
/override ci/prow/images
/label acknowledge-critical-fixes-only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 7, 2025

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit abd9b74 into openshift:master Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants