Skip to content

OCPBUGS-52293: extensions: make rhel-9.4-appstream global#1784

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jlebon:pr/extensions-ocp
Apr 4, 2025
Merged

OCPBUGS-52293: extensions: make rhel-9.4-appstream global#1784
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
jlebon:pr/extensions-ocp

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Apr 2, 2025

There's a subtlety here that's causing issues. Any repo that's available on all arches needs to be listed in the global repos list. Otherwise, we may have skew across arches for packages not even related to the extensions for which the repo was added.

See also: https://issues.redhat.com/browse/OCPBUGS-52293

@openshift-ci openshift-ci Bot requested review from cgwalters and madhu-pillai April 2, 2025 14:55
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@jlebon jlebon changed the title extensions: make rhel-9.4-appstream global OCPBUGS-52293: extensions: make rhel-9.4-appstream global Apr 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@jlebon: This pull request references Jira Issue OCPBUGS-52293, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

There's a subtlety here that's causing issues. Any repo that's available on all arches needs to be listed in the global repos list. Otherwise, we may have skew across arches for packages not even related to the extensions for which the repo was added.

See also: https://issues.redhat.com/browse/OCPBUGS-52293

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 2, 2025
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Apr 2, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 2, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@jlebon: This pull request references Jira Issue OCPBUGS-52293, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 2, 2025
@openshift-ci openshift-ci Bot requested a review from mike-nguyen April 2, 2025 15:27
Copy link
Copy Markdown
Member

@ravanelli ravanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it and got:

pixman-0.40.0-6.el9_3.s390x (rhel-9.4-appstream)
pixman-0.40.0-6.el9_3.x86_64 (rhel-9.4-appstream)

The build completed ok as well.
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2025
@ravanelli
Copy link
Copy Markdown
Member

/retest

There's a subtlety here that's causing issues. Any repo that's available
on all arches needs to be listed in the global repos list. Otherwise,
we may have skew across arches for packages not even related to the
extensions for which the repo was added.

See also: https://issues.redhat.com/browse/OCPBUGS-52293
@jlebon jlebon force-pushed the pr/extensions-ocp branch from 5e6577e to d01f69a Compare April 4, 2025 19:13
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2025
@ravanelli
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, ravanelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 902882d and 2 for PR HEAD d01f69a in total

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Apr 4, 2025

OKD will be fixed in #1498.
/override ci/prow/okd-scos-images
/override ci/prow/okd-scos-e2e-aws-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2025

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/okd-scos-e2e-aws-ovn, ci/prow/okd-scos-images

Details

In response to this:

OKD will be fixed in #1498.
/override ci/prow/okd-scos-images
/override ci/prow/okd-scos-e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2025

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit a9ea6d8 into openshift:master Apr 4, 2025
14 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@jlebon: Jira Issue OCPBUGS-52293: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52293 has been moved to the MODIFIED state.

Details

In response to this:

There's a subtlety here that's causing issues. Any repo that's available on all arches needs to be listed in the global repos list. Otherwise, we may have skew across arches for packages not even related to the extensions for which the repo was added.

See also: https://issues.redhat.com/browse/OCPBUGS-52293

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants