Publish redhat-coreos config sources#413
Publish redhat-coreos config sources#413openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
| @@ -0,0 +1,20 @@ | |||
| # This file documents currently known-to-fail kola tests. It is consumed by | |||
There was a problem hiding this comment.
This file should probably be removed.
|
I think we can drop the |
|
@darkmuggle @bh7cw @mike-nguyen @ravanelli This change will likely intersect with some of the pipeline work you folks are responsible for. |
|
/approve The first step is getting things imported; I imagine there are going to be follow-ups to refine this. But as a start, this looks reasonable. |
|
I have no objections. ✔️ |
|
Overall |
Yeah true, I can try to drop that. |
cgwalters
force-pushed
the
import-rhcos-config
branch
from
3e150e6 to
6349008
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
OK updated to address comments, dropping draft! |
cgwalters
force-pushed
the
import-rhcos-config
branch
from
6349008 to
3178c3d
Compare
| @@ -0,0 +1,143 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Do we still need this now that it lives in the MCO?
There was a problem hiding this comment.
This is just reflecting the state of the internal git repository; let's not try to also change it at the same time.
There was a problem hiding this comment.
I mean if we succeed at this, then we could do a PR to drop that script and have it tested by Prow launching a cluster in Azure!
|
Seems like we are in a good position to move forward. /approve |
|
OK, tested locally and verified that it's up to date. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 participants
Today the redhat-coreos config git repository (equivalent of https://github.com/coreos/fedora-coreos-config ) lives internally to the RH firewall. This is problematic for many reasons - we're not consistently publishing the sources here, and also inhibits our integration with the upstream OpenShift CI (Prow).
This PR imports the config. I propose we move it to Github canonically.