extensions.yaml: New declarative file for extensions#455
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Dec 2, 2020
Merged
Conversation
openshift-ci-robot
added
the
approved
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Nov 30, 2020
Pairs with openshift/os#455 Since extensions are now a core part of OpenShift 4 (particularly RT kernel) let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git.
Member
Author
|
Pairs with coreos/coreos-assembler#1916 After we land both we can delete the shell script implementation. (Though I currently skipped over the special RT kernel versioning handling) |
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Nov 30, 2020
Pairs with openshift/os#455 Since extensions are now a core part of OpenShift 4 (particularly RT kernel) let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git.
I was trying to upload a custom oscontainer with a patched rpm-ostree to help someone test it: https://bugzilla.redhat.com/show_bug.cgi?id=1865839 And apparently made it incorrectly; doing the build involves copy-pasting stuff from the internal Jenkins glue. Let's accomplish two things: - Make the list of extensions properly declarative, distinct from the code implementing it - Move the logic for sticking it into the oscontainer as part of coreos-assembler (making this whole repo more declarative) And also therefore making oscontainer generation more ergonomic to run locally.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Dec 2, 2020
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too
cgwalters
force-pushed
the
extensions-declarative
branch
from
a6ffcfe to
4324329
Compare
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, jlebon, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Dec 3, 2020
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 22, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 22, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 26, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 26, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Feb 26, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 18, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 23, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 26, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 29, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 30, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 31, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 31, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Mar 31, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Apr 1, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Apr 9, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Apr 22, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Apr 27, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
Apr 28, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
ravanelli
pushed a commit
to ravanelli/coreos-assembler
that referenced
this pull request
May 10, 2021
Pairs with openshift/os#455 Add an `oscontainer.yaml` which allows configuring (currently) just the `FROM` line equivalent. This helps keep things declarative in the config instead of part of the pipeline. And since extensions are now a core part of OpenShift 4 (particularly RT kernel) which also uses the oscontainer, let's lift the logic to generate those bits of the oscontainer into this repo and out of the config git. Both of these are part of the general philosophy we've had that: - config git is declarative config - coreos-assembler is the mechanism - a pipeline just scripts coreos-assembler in a way that's easy to reproduce with plain podman too Signed-off-by: Renata Ravanelli <rravanel@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to upload a custom oscontainer with a patched
rpm-ostree to help someone test it:
https://bugzilla.redhat.com/show_bug.cgi?id=1865839
And apparently made it incorrectly; doing the build involves
copy-pasting stuff from the internal Jenkins glue.
Let's accomplish two things:
from the code implementing it
part of coreos-assembler (making this whole repo more declarative)
And also therefore making oscontainer generation more ergonomic
to run locally.