scripts: Remove download-extensions#459
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Dec 7, 2020
Merged
scripts: Remove download-extensions#459openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
There's some logic I didn't currently preserve from this in the move into coreos-assembler around kernel/kernel-headers matching. coreos/coreos-assembler#1916 I will look at re-adding that. But short term we don't actually have that problem right now and I'd like to get the 4.7 pipeline switched over to the new model so we don't have duplication. The goal here is to make it very "cosa like" to upload the oscontainer because it needs to be trivial for other people to do outside of a pipeline. Because this is git, when we need some of this code again we can find it in the history.
openshift-ci-robot
added
the
approved
Member
Author
|
(Also scripts/verify-kernel-versions should be folded into; something more declarative like |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's some logic I didn't currently preserve from this
in the move into coreos-assembler around kernel/kernel-headers
matching.
coreos/coreos-assembler#1916
I will look at re-adding that. But short term we don't
actually have that problem right now and I'd like to
get the 4.7 pipeline switched over to
the new model so we don't have duplication.
The goal here is to make it very "cosa like" to upload the
oscontainer because it needs to be trivial for other people
to do outside of a pipeline.
Because this is git, when we need some of this code again we
can find it in the history.