Skip to content

[release-4.8] test: add test to check rhaos package versions#637

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
mike-nguyen:48checkpackages
Oct 28, 2021
Merged

[release-4.8] test: add test to check rhaos package versions#637
openshift-merge-robot merged 1 commit intoopenshift:release-4.8from
mike-nguyen:48checkpackages

Conversation

@mike-nguyen
Copy link
Copy Markdown
Member

@mike-nguyen mike-nguyen commented Sep 24, 2021

Add test to verify that rhaos package versions match the OpenShift
version.

This is a cherry-pick of #635

@mike-nguyen
test: add test to check rhaos package versions
eed0a5a 
Add test to verify that rhaos package versions match the OpenShift
version.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 24, 2021

@mike-nguyen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.8] test: add test to check rhaos package versions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from ashcrow and dustymabe September 24, 2021 18:08
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@mike-nguyen
Copy link
Copy Markdown
Member Author

mike-nguyen commented Sep 30, 2021 •
edited
Loading 

Sep 24 19:11:56 qemu0 kola-runext-misc-ro.sh[1615]: ++ rpm -qa
Sep 24 19:11:57 qemu0 kola-runext-misc-ro.sh[1615]: + [[ -n nss-altfiles-2.18.1-12.rhaos4.5.el8.x86_64 ]]
Sep 24 19:11:57 qemu0 kola-runext-misc-ro.sh[1615]: + fatal 'Error: rhaos packages do not match OpenShift version'

nss-altfiles has rhaos4.5 instead of rhaos4.8

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Oct 1, 2021

nss-altfiles has rhaos4.5 instead of rhaos4.8

In 4.9+ we are using nss-altfiles-2.18.1-12.el8 which appears identical to nss-altfiles-2.18.1-12.rhaos4.5.el8

Seems like we should be able to use the repo-packages stanza in the manifest to make sure we are getting nss-altfiles from the RHEL repos.

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Oct 21, 2021

It looks like that version of nss-altfiles was already included in 4.5 + 4.6, but we can stop it from getting tagged into newer versions - https://issues.redhat.com/browse/ART-3421

miabbott added a commit to miabbott/os that referenced this pull request Oct 27, 2021
@miabbott
Bug 2017471: ensure nss-altfiles comes from AppStream
7d48017 
In openshift#637, it was observed that `nss-altfiles` could come from the RHAOS
repos, which is unnecessary since the same version exists in the RHEL8
AppStream repos.  The package has since been untagged from the RHAOS
repo, but to ensure that we always get the package from AppStream we'll
pin to the specific version.  (The version hasn't changed since Apr 2019)
@miabbott miabbott mentioned this pull request Oct 27, 2021
Merged
@miabbott
Copy link
Copy Markdown
Member

miabbott commented Oct 27, 2021

/retest

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Oct 28, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miabbott, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [miabbott,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 98d654e into openshift:release-4.8 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@dustymabe dustymabe Awaiting requested review from dustymabe

Assignees

@miabbott miabbott

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mike-nguyen @miabbott @openshift-merge-robot