extensions: Remove references to qemu-kiwi and advanced-virt#740
extensions: Remove references to qemu-kiwi and advanced-virt#740openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
Hi @etrunko. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
/ok-to-test Cool, that's a nice cleanup. Let's also delete the repo file from the internal redhat-coreos repo. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Looks like we need an update to the repos defined in |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
I think we have a catch-22 here, we can't do that until it's released, right? I think we need to handle this by branching/versioning. We need to add rhel8.6 as an option, not replace the current version. And we should make a |
Correct, we don't have the ability to use any 8.6 content yet (due to legal reasons), so a new branch sounds like a reasonable compromise. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Alright, I don't have any experience with this, so can you please provide more information on how should I proceed here? |
|
/hold
No worries, it's not your fault or task, it's more on the RHCOS team to figure out. This is just the first PR that requires 8.6. |
|
/test build-test-qemu |
|
The error logs: |
|
A little confused about the failed logs, qemu-kvm-core is included in 'rhel-8-appstream', does this mean we should add |
|
Edit 1:
Edit 2:
|
|
Yes, it is confusing, the module still exists, as it is the way the virtualization packages are built with RHEL 8. This is not going to change until RHEL 9. What changed from 8.4 to 8.6 is that the same version of the virt packages are available in both AV and regular RHEL repositories. So we do not require the AV repository to be enabled. |
I think this is what we need. |
From RHEL 8.6 onwards, there is no qemu-kiwi package nor advanced virtualization reposiory. The kata-containers package has been adjusted to require the qemu-kvm-core pacakge instead. Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
|
Hm, did we lose having build-test-qemu be a gating context? |
|
@etrunko: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, etrunko, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
From RHEL 8.6 onwards, there is no qemu-kiwi package nor advanced
virtualization reposiory. The kata-containers package has been adjusted
to require the qemu-kvm-core pacakge instead.
Signed-off-by: Eduardo Lima (Etrunko) etrunko@redhat.com