Skip to content

extensions: Remove references to qemu-kiwi and advanced-virt#740

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
etrunko:master
Mar 31, 2022
Merged

extensions: Remove references to qemu-kiwi and advanced-virt#740
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
etrunko:master

Conversation

@etrunko
Copy link
Copy Markdown
Contributor

@etrunko etrunko commented Mar 7, 2022

From RHEL 8.6 onwards, there is no qemu-kiwi package nor advanced
virtualization reposiory. The kata-containers package has been adjusted
to require the qemu-kvm-core pacakge instead.

Signed-off-by: Eduardo Lima (Etrunko) etrunko@redhat.com

@openshift-ci openshift-ci Bot requested review from ashcrow and bgilbert March 7, 2022 18:58
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 7, 2022

Hi @etrunko. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow ashcrow requested review from aaradhak and jlebon and removed request for ashcrow and bgilbert March 7, 2022 19:09
@cgwalters
Copy link
Copy Markdown
Member

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Mar 7, 2022

/ok-to-test
/lgtm

Cool, that's a nice cleanup. Let's also delete the repo file from the internal redhat-coreos repo.

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Mar 8, 2022

Problem: conflicting requests
  - nothing provides qemu-kiwi >= 5.1.0-16 needed by kata-containers-2.3.2-2.el8.x86_64

Looks like we need an update to the repos defined in openshift/release to point to RHEL 8.6

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Copy Markdown
Member

Looks like we need an update to the repos defined in openshift/release to point to RHEL 8.6

I think we have a catch-22 here, we can't do that until it's released, right? I think we need to handle this by branching/versioning. We need to add rhel8.6 as an option, not replace the current version. And we should make a main-8.6 branch here, where this patch could merge.

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Mar 8, 2022

Looks like we need an update to the repos defined in openshift/release to point to RHEL 8.6

I think we have a catch-22 here, we can't do that until it's released, right? I think we need to handle this by branching/versioning. We need to add rhel8.6 as an option, not replace the current version. And we should make a main-8.6 branch here, where this patch could merge.

Correct, we don't have the ability to use any 8.6 content yet (due to legal reasons), so a new branch sounds like a reasonable compromise.

@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@etrunko
Copy link
Copy Markdown
Contributor Author

etrunko commented Mar 8, 2022

Looks like we need an update to the repos defined in openshift/release to point to RHEL 8.6

I think we have a catch-22 here, we can't do that until it's released, right? I think we need to handle this by branching/versioning. We need to add rhel8.6 as an option, not replace the current version. And we should make a main-8.6 branch here, where this patch could merge.

Correct, we don't have the ability to use any 8.6 content yet (due to legal reasons), so a new branch sounds like a reasonable compromise.

Alright, I don't have any experience with this, so can you please provide more information on how should I proceed here?

@cgwalters
Copy link
Copy Markdown
Member

/hold
until we can set things up so that CI can work and this can merge.

Alright, I don't have any experience with this, so can you please provide more information on how should I proceed here?

No worries, it's not your fault or task, it's more on the RHCOS team to figure out. This is just the first PR that requires 8.6.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2022
@HuijingHei
Copy link
Copy Markdown
Contributor

/test build-test-qemu

@HuijingHei
Copy link
Copy Markdown
Contributor

The error logs:

Importing rpm-md...done
rpm-md repo 'rhel-8-baseos'; generated: 2022-03-23T18:28:26Z solvables: 1718
rpm-md repo 'rhel-8-appstream'; generated: 2022-03-23T18:29:24Z solvables: 6603
rpm-md repo 'rhel-8-server-ose'; generated: 2022-03-31T01:08:29Z solvables: 491
rpm-md repo 'rhel-8-fast-datapath'; generated: 2022-03-30T16:21:12Z solvables: 705
rpm-md repo 'rhel-8-nfv'; generated: 2022-03-23T18:27:47Z solvables: 20
Resolving dependencies...done
error: Could not depsolve transaction; 1 problem detected:
 Problem: package kata-containers-2.3.3-3.el8.x86_64 requires qemu-kvm-core >= 6.2.0, but none of the providers can be installed
  - conflicting requests
  - package qemu-kvm-core-15:6.2.0-8.module+el8.6.0+14324+050a5215.x86_64 is filtered out by modular filtering

@HuijingHei
Copy link
Copy Markdown
Contributor

A little confused about the failed logs, qemu-kvm-core is included in 'rhel-8-appstream', does this mean we should add rhel-8-appstream here?

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Mar 31, 2022

I think we need to keep the virt:av module enabled here, since qemu-kvm-core is part of the virt module.

But modules continue to confuse me to this day, so I could be wrong. 🤷

Edit 1:
Since the whole point of this is to remove the dependency on RHEL AV, perhaps it's just a matter of qemu-kvm-core not being part of AppStream as part of the 8.6 Beta?

I don't see any qemu-kvm-core packages on the internal mirror of the 8.6 Beta content...

Edit 2:
Nope, I missed it but it looks like it is part of a module, so I am back to scratching my head...

qemu-kvm-core-6.2.0-8.module+el8.6.0+14324+050a5215.x86_64.rpm

@etrunko
Copy link
Copy Markdown
Contributor Author

etrunko commented Mar 31, 2022

Yes, it is confusing, the module still exists, as it is the way the virtualization packages are built with RHEL 8. This is not going to change until RHEL 9.

What changed from 8.4 to 8.6 is that the same version of the virt packages are available in both AV and regular RHEL repositories. So we do not require the AV repository to be enabled. Do you know if there is a call to dnf module enable virt:av somewhere? (this is exactly what this commit is removing)

@etrunko
Copy link
Copy Markdown
Contributor Author

etrunko commented Mar 31, 2022

A little confused about the failed logs, qemu-kvm-core is included in 'rhel-8-appstream', does this mean we should add rhel-8-appstream here?

I think this is what we need.

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
From RHEL 8.6 onwards, there is no qemu-kiwi package nor advanced
virtualization reposiory. The kata-containers package has been adjusted
to require the qemu-kvm-core pacakge instead.

Signed-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>
@cgwalters
Copy link
Copy Markdown
Member

Hm, did we lose having build-test-qemu be a gating context?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 31, 2022

@etrunko: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, etrunko, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Copy Markdown
Member

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit 74f7cc2 into openshift:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants