Skip to content

adds zacks RHCOS OCI braindump#780

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cheesesashimi:zzlotnik/rhcos-oci-braindump
May 6, 2022
Merged

adds zacks RHCOS OCI braindump#780
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cheesesashimi:zzlotnik/rhcos-oci-braindump

Conversation

@cheesesashimi
Copy link
Copy Markdown
Member

This is meant to document how and why the RHCOS OCI image builds work the way they do. This is definitely in a draft state, but I aim to make the document better with review feedback.

@openshift-ci openshift-ci Bot requested review from ashcrow and jlebon April 18, 2022 21:48
@ashcrow ashcrow requested review from sohankunkerkar and removed request for ashcrow April 19, 2022 13:01
@travier
Copy link
Copy Markdown
Member

travier commented Apr 21, 2022

/assign @travier

Comment thread docs/rhcos-oci-braindump.md Outdated
Comment thread docs/rhcos-oci-braindump.md Outdated
@miabbott
Copy link
Copy Markdown
Member

miabbott commented May 5, 2022

/approve

Great content, just a couple of small nits (not blocking)

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@cheesesashimi cheesesashimi force-pushed the zzlotnik/rhcos-oci-braindump branch from 93e51cd to a92f7e1 Compare May 5, 2022 18:20
@cgwalters
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, cheesesashimi, miabbott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bdca5b0 into openshift:master May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants