add 25rhcos-azure-udev overlay; drop 25rhcos-azure-udev-rules overlay#785
Closed
dustymabe wants to merge 4 commits intoopenshift:masterfrom
Closed
add 25rhcos-azure-udev overlay; drop 25rhcos-azure-udev-rules overlay#785dustymabe wants to merge 4 commits intoopenshift:masterfrom
dustymabe wants to merge 4 commits intoopenshift:masterfrom
Conversation
This reverts commit 90bd86e.
The WALinuxAgent-udev package exists now. This reverts commit 5cd6441.
The directory is no longer needed because the 25rhcos-azure-udev-rules overlay got removed in the previous commit.
This migrates the glue code that installs the udev rules into the initramfs to an overlay module in the RHCOS repo. It was no longer needed in FCOS and removed from the overlay there in [1]. [1] coreos/fedora-coreos-config#1686
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
For this we'll wait for two things.
|
Member
@dustymabe both of these have completed; I think you can proceed with this PR |
openshift-ci
Bot
added
the
needs-rebase
Contributor
|
@dustymabe: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
travier
added a commit
to travier/os
that referenced
this pull request
May 24, 2022
For RHEL 8.6, we no longer need the 25rhcos-azure-udev-rules overlay because the WALinuxAgent-udev package exists. We do still need the glue code that copies the udev files into the initramfs via a dracut module, thought. This is not needed for RHEL 9.0. This migrates the glue code that installs the udev rules into the initramfs to an overlay module in the RHCOS repo for 8.6. It was no longer needed in FCOS and removed from the overlay there in [1]. [1] coreos/fedora-coreos-config#1686 From: openshift#785
travier
added a commit
to travier/os
that referenced
this pull request
May 24, 2022
For RHEL 8.6, we no longer need the 25rhcos-azure-udev-rules overlay because the WALinuxAgent-udev package exists. We do still need the glue code that copies the udev files into the initramfs via a dracut module, thought. This is not needed for RHEL 9.0. This migrates the glue code that installs the udev rules into the initramfs to an overlay module in the RHCOS repo for 8.6. It was no longer needed in FCOS and removed from the overlay there in [1]. [1] coreos/fedora-coreos-config#1686 From: openshift#785
Member
|
I merged this one into #803 |
travier
added a commit
to travier/os
that referenced
this pull request
May 25, 2022
For RHEL 8.6, we no longer need the 25rhcos-azure-udev-rules overlay because the WALinuxAgent-udev package exists. We do still need the glue code that copies the udev files into the initramfs via a dracut module, thought. This is not needed for RHEL 9.0. This migrates the glue code that installs the udev rules into the initramfs to an overlay module in the RHCOS repo for 8.6. It was no longer needed in FCOS and removed from the overlay there in [1]. [1] coreos/fedora-coreos-config#1686 From: openshift#785
travier
added a commit
to travier/os
that referenced
this pull request
May 25, 2022
For RHEL 8.6, we no longer need the 25rhcos-azure-udev-rules overlay because the WALinuxAgent-udev package exists. We do still need the glue code that copies the udev files into the initramfs via a dracut module, thought. This is not needed for RHEL 9.0. This migrates the glue code that installs the udev rules into the initramfs to an overlay module in the RHCOS repo for 8.6. It was no longer needed in FCOS and removed from the overlay there in [1]. [1] coreos/fedora-coreos-config#1686 From: openshift#785
Contributor
|
This addresses a 4.11 regression tracked in https://bugzilla.redhat.com/show_bug.cgi?id=2092966. |
Merged
travier
added a commit
to travier/os
that referenced
this pull request
Jun 3, 2022
For RHEL 8.6, we no longer need the 25rhcos-azure-udev-rules overlay because the WALinuxAgent-udev package exists. We do still need the glue code that copies the udev files into the initramfs via a dracut module, thought. This is not needed for RHEL 9.0. This migrates the glue code that installs the udev rules into the initramfs to an overlay module in the RHCOS repo for 8.6. It was no longer needed in FCOS and removed from the overlay there in [1]. [1] coreos/fedora-coreos-config#1686 From: openshift#785
Member
|
/close |
Contributor
|
@travier: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need the 25rhcos-azure-udev-rules overlay because
the WALinuxAgent-udev package exists in el8. We do still need
the glue code that copies the udev files into the initramfs
via a dracut module, thought. Can drop that in el9.