Skip to content

image.yaml: disable secure boot#888

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
mike-nguyen:secure_boot
Jul 12, 2022
Merged

image.yaml: disable secure boot#888
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
mike-nguyen:secure_boot

Conversation

@mike-nguyen
Copy link
Copy Markdown
Member

Secure boot enabled by default causes issues with unsigned kernel
modules.

ref: https://bugzilla.redhat.com/show_bug.cgi?id=2106055

Requires coreos/coreos-assembler#2971

@openshift-ci openshift-ci Bot requested review from aaradhak and cgwalters July 11, 2022 20:47
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@cgwalters
Copy link
Copy Markdown
Member

/lgtm
as is but (in case you do any followup) I think it'd be good to also put a doc comment above the code in image.yaml linking to the bug.

(git annotate/blame will get one there, but better to save the step for stuff like this)

Comment thread image.yaml
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2022
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2022
@mike-nguyen
Copy link
Copy Markdown
Member Author

Added comment with link to BZ

@travier
Copy link
Copy Markdown
Member

travier commented Jul 12, 2022

/hold
/lgtm

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
Secure boot enabled by default causes issues with unsigned kernel
modules.

ref: https://bugzilla.redhat.com/show_bug.cgi?id=2106055
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@travier
Copy link
Copy Markdown
Member

travier commented Jul 12, 2022

/lgtm
/unhold
We don't have VMware testing here so let's move forward.

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 12, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, mike-nguyen, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,mike-nguyen,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 12, 2022

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit 8041e75 into openshift:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants