manifests: Prepare for variant support in COSA and add RHEL 9.0 & SCOS variants#901
Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom Jul 20, 2022
Merged
Conversation
travier
changed the title
openshift-ci
Bot
added
the
approved
Member
Author
This was referenced Jul 19, 2022
Member
|
/retest |
Member
|
I verified (after rebasing this on current master) that switching to this branch is a no-op for an existing |
Member
|
OK I got a local c9s build with two changes; first, we can use the |
Member
|
Second, I know there's debate about "where to build ocp packages" but we already do ship https://mirror.openshift.com/pub/openshift-v4/amd64/dependencies/rpms/4.11-el8-beta/ So via e.g. We get that stuff; that one isn't gated on subscriptions so we can just include it by default. |
travier
force-pushed
the
scos4
branch
3 times, most recently
from
10f3c69 to
20ab24a
Compare
Only add the manifests and do not enable CI yet.
Only add the manifests and do not enable CI yet.
Member
|
/override ci/prow/periodic-images |
Contributor
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/periodic-images DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
/lgtm |
Member
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, travier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@travier: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Jul 29, 2022
Several variants may be provided from a single Git config repo: - If no variant is explicitly selected then the default `manifest.yaml` will be used. - If there is no `manifest.yaml` file provided by default in the repo, then COSA will read the `variant_default` file to figure out which variant to use by default. - If you explicitly specify a variant as parameter then COSA will read the corresponding `variant_$VARIANT` file and use that as default instead, overriding any default set in the repo. See: - openshift/os#852 - openshift/os#901 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Jul 29, 2022
Several variants may be provided from a single Git config repo: - If no variant is explicitly selected then the default `manifest.yaml` will be used. - If there is no `manifest.yaml` file provided by default in the repo, then COSA will read the `variant_default` file to figure out which variant to use by default. - If you explicitly specify a variant as parameter then COSA will read the corresponding `variant_$VARIANT` file and use that as default instead, overriding any default set in the repo. See: - openshift/os#852 - openshift/os#901 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Jul 29, 2022
Several variants may be provided from a single Git config repo: - If no variant is explicitly selected then the default `manifest.yaml` will be used. - If there is no `manifest.yaml` file provided by default in the repo, then COSA will read the `variant_default` file to figure out which variant to use by default. - If you explicitly specify a variant as parameter then COSA will read the corresponding `variant_$VARIANT` file and use that as default instead, overriding any default set in the repo. See: - openshift/os#852 - openshift/os#901 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 2, 2022
Several variants may be provided from a single Git config repo: - If no variant is explicitly selected then the default `manifest.yaml` will be used. - If there is no `manifest.yaml` file provided by default in the repo, then COSA will read the `variant_default` file to figure out which variant to use by default. - If you explicitly specify a variant as parameter then COSA will read the corresponding `variant_$VARIANT` file and use that as default instead, overriding any default set in the repo. See: - openshift/os#852 - openshift/os#901 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 4, 2022
Several variants may be provided from a single Git config repo: - If no variant is explicitly selected then the default `manifest.yaml` will be used. - If there is no `manifest.yaml` file provided by default in the repo, then COSA will read the `variant_default` file to figure out which variant to use by default. - If you explicitly specify a variant as parameter then COSA will read the corresponding `variant_$VARIANT` file and use that as default instead, overriding any default set in the repo. See: - openshift/os#852 - openshift/os#901 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 22, 2022
Several variants may be provided from a single Git config repo: - If no variant is explicitly selected then the default `manifest.yaml` will be used. - If there is no `manifest.yaml` file provided by default in the repo, then COSA will read the `variant_default` file to figure out which variant to use by default. - If you explicitly specify a variant as parameter then COSA will read the corresponding `variant_$VARIANT` file and use that as default instead, overriding any default set in the repo. See: - openshift/os#852 - openshift/os#901 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 23, 2022
Several variants may be provided from a single Git config repo: - If no variant is explicitly selected then the default `manifest.yaml` will be used. - If there is no `manifest.yaml` file provided by default in the repo, then COSA will read the `variant_default` file to figure out which variant to use by default. - If you explicitly specify a variant as parameter then COSA will read the corresponding `variant_$VARIANT` file and use that as default instead, overriding any default set in the repo. See: - openshift/os#852 - openshift/os#901 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 23, 2022
Several variants may be provided from a single Git config repo: - If no variant is explicitly selected then the default `manifest.yaml` will be used. - If there is no `manifest.yaml` file provided by default in the repo, then COSA will read the `variant_default` file to figure out which variant to use by default. - If you explicitly specify a variant as parameter then COSA will read the corresponding `variant_$VARIANT` file and use that as default instead, overriding any default set in the repo. See: - openshift/os#852 - openshift/os#901 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 25, 2022
On top of the defaut variant, a config repo may include aditional optional variants. The variant used is selected at `cosa init` with the `--variant` option and the value is recorded locally in `src/config.json`. See: - openshift/os#852 - openshift/os#901 - https://github.com/openshift/os/pull/XYZ # TODO Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 25, 2022
On top of the defaut variant, a config repo may include aditional optional variants. The variant used is selected at `cosa init` with the `--variant` option and the value is recorded locally in `src/config.json`. See: - openshift/os#852 - openshift/os#901 - openshift/os#958 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 26, 2022
On top of the defaut variant, a config repo may include aditional optional variants. The variant used is selected at `cosa init` with the `--variant` option and the value is recorded locally in `src/config.json`. See: - openshift/os#852 - openshift/os#901 - openshift/os#958 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 26, 2022
On top of the defaut variant, a config repo may include aditional optional variants. The variant used is selected at `cosa init` with the `--variant` option and the value is recorded locally in `src/config.json`. See: - openshift/os#852 - openshift/os#901 - openshift/os#958 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to travier/coreos-assembler
that referenced
this pull request
Aug 26, 2022
On top of the defaut variant, a config repo may include aditional optional variants. The variant used is selected at `cosa init` with the `--variant` option and the value is recorded locally in `src/config.json`. See: - openshift/os#852 - openshift/os#901 - openshift/os#958 Reworks: 480c239 init: Require specifying a config repository
travier
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Aug 29, 2022
On top of the defaut variant, a config repo may include aditional optional variants. The variant used is selected at `cosa init` with the `--variant` option and the value is recorded locally in `src/config.json`. See: - openshift/os#852 - openshift/os#901 - openshift/os#958 Reworks: 480c239 init: Require specifying a config repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only adds the manifests and prepare the repo layout to match the upcoming COSA changes. This should be completely transparent for now but should make manual testing of RHCOS 9.0 & SCOS 9 easier.
manifests: Prepare for variant support in COSA
manifests: Add RHEL 9.0 variant
Only add the manifests and do not enable CI yet.
manifests: Add SCOS variant
Only add the manifests and do not enable CI yet.