CI: Partially enable RHCOS 9 & SCOS testing#937
CI: Partially enable RHCOS 9 & SCOS testing#937openshift-ci[bot] merged 3 commits intoopenshift:masterfrom
Conversation
- Only build RHCOS9, only run basic tests for SCOS - Includes temporary workaround for variant selection for non default variants. Will be removed once COSA support for variants is completed.
travier
changed the title
openshift-ci
Bot
added
the
approved
| repos: | ||
| - rhel-9-nfv | ||
| # Temporarily included for kata-containers | ||
| - rhel-8-server-ose |
There was a problem hiding this comment.
On this topic, one thing we should probably support in rpm-ostree is to have repos mentioned in repo-packages be enabled but used only for the mentioned packages. This would make things like this cleaner, so that we don't accidentally also ship other things from that repo that we didn't intend because of EVR ordering funkiness.
There was a problem hiding this comment.
Agree. Right now I'm doing that manually in the repo configs: https://github.com/openshift/os/pull/937/files#diff-cf4ac67e6195e36ef10dd53e72af30a0346517d3faf3857f88e74204c7373e3bR94
# Temporary workaround until we have all packages for RHCOS 9
curl -L "http://base-${ocpver_mut}-rhel86.ocp.svc.cluster.local" -o "src/config/tmp.repo"
awk '/rhel-8-server-ose/,/^$/' "src/config/tmp.repo" > "src/config/ocp86.repo"
echo "includepkgs=kata-containers,skopeo" >> "src/config/ocp86.repo"
rm "src/config/tmp.repo"
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
LGTM! I didn't review the symlink handling bits in depth (since we're cleaning that up soon anyway).
| kola_test_metal_light | ||
| # kola_test_metal | ||
| ;; | ||
| "explicitely-disabled-test") |
There was a problem hiding this comment.
It's a way to have an entry-point for Prow that works but does nothing so that we can add new tests in the Prow config without having to do changes in this repo first.
There was a problem hiding this comment.
- Add a new test in openshift/release that calls this name
- Make a PR that changes what this does
- When ready, update openshift/release to get a new name
- update your PR for the new name and merge
Without that, you have to hijack an existing test to test a new one without breaking CI for other PRs.
There was a problem hiding this comment.
Gotcha, makes sense. Might help to add a comment there explaining that. Then we can link to it too for anyone working on adding new tests.
There was a problem hiding this comment.
Thinking about this more, I've simplified it in a5d371c (#905)
|
Aside: re. the Prow tests, any reason we don't combine the -qemu and -metal ones into a single test? E.g. have only |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, travier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That's what we had before but this meant that we had a single test that lasted 3-4h. The two tests right now take 1h30 (qemu) and 2h30 (metal). I'll make a test PR to see how things look like now if we merge the tests. |
|
@travier: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 participants
Let's enable some CI that works right now so that at least we don't regress.
manifests: Add shared manifest for EL9 variants
repos: Update C9S SIG NFV repo name
ci: Partially enable RHCOS 9 & SCOS testing
variants. Will be removed once COSA support for variants is completed.