Skip to content

scos: enable some networking cases#952

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
HuijingHei:enable-network-cases
Aug 22, 2022
Merged

scos: enable some networking cases#952
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
HuijingHei:enable-network-cases

Conversation

@HuijingHei
Copy link
Copy Markdown
Contributor

@HuijingHei HuijingHei commented Aug 15, 2022

Fixed selinux-policy-34.1.39-1.el9.noarch is included in scos,
should enable related cases.
See:

Fix #909

@openshift-ci openshift-ci Bot requested review from dustymabe and jmarrero August 15, 2022 05:50
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2022
Fixed `selinux-policy-34.1.39-1.el9.noarch` is included in scos,
should enable related cases.
See:
- https://bugzilla.redhat.com/show_bug.cgi?id=2111069

Fix openshift#909
@HuijingHei HuijingHei force-pushed the enable-network-cases branch from a95af07 to 641b362 Compare August 15, 2022 05:50
@HuijingHei
Copy link
Copy Markdown
Contributor Author

Build scos locally and run the related cases, results are passed

[coreos-assembler]$ kola run ext.config.shared.networking.prefer-ignition-networking ext.config.shared.networking.force-persist-ip ext.config.shared.networking.mtu-on-bond-kargs
=== RUN   ext.config.shared.networking.mtu-on-bond-kargs
=== RUN   ext.config.shared.networking.prefer-ignition-networking
=== RUN   ext.config.shared.networking.force-persist-ip
--- PASS: ext.config.shared.networking.mtu-on-bond-kargs (73.88s)
--- PASS: ext.config.shared.networking.force-persist-ip (65.25s)
--- PASS: ext.config.shared.networking.prefer-ignition-networking (55.36s)
PASS, output in tmp/kola/qemu-unpriv-2022-08-15-0510-18902

@travier
Copy link
Copy Markdown
Member

travier commented Aug 22, 2022

/lgtm

@travier
Copy link
Copy Markdown
Member

travier commented Aug 22, 2022

Thanks!

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 22, 2022

@HuijingHei: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 05f485b into openshift:master Aug 22, 2022
@HuijingHei HuijingHei deleted the enable-network-cases branch September 6, 2022 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SCOS: systemd-network-generator.service: Failed to create unit file /run/systemd/network/91-default.network

3 participants