OCPBUGS-595: overlay: Add `rhcos-selinux-policy-upgrade.service` by cgwalters · Pull Request #962 · openshift/os

cgwalters · 2022-08-29T13:57:58Z

This will auto rebuild the policy if we detect local modifications;
it is only needed before RHEL 8.7 when we'll pick up the
combined underlying work from
https://bugzilla.redhat.com/show_bug.cgi?id=2057497

openshift-ci · 2022-08-29T13:58:23Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2022-08-29T13:58:30Z

@cgwalters: This pull request references Jira Issue OCPBUGS-595, which is invalid:

expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This will auto rebuild the policy if we detect local modifications;
it is only needed before RHEL 8.7 when we'll pick up the
combined underlying work from
https://bugzilla.redhat.com/show_bug.cgi?id=2057497

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cgwalters · 2022-08-29T14:00:55Z

/jira refresh

openshift-ci-robot · 2022-08-29T14:00:58Z

@cgwalters: This pull request references Jira Issue OCPBUGS-595, which is invalid:

expected the bug to target the "4.12.0" version, but it targets "4.12" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cgwalters · 2022-08-29T14:01:25Z

/jira refresh

openshift-ci-robot · 2022-08-29T14:01:33Z

@cgwalters: This pull request references Jira Issue OCPBUGS-595, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mike-nguyen

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cgwalters · 2022-08-29T17:17:49Z

OK lifting draft, now tested manually, and I added an automated kola test.

travier · 2022-08-29T17:45:24Z

+  *) echo "Assuming we have new enough ostree"; exit 0;;
+esac
+
+ls -al /{usr/,}etc/selinux/targeted/policy/policy.31


I'm not 100% sure this is stable across all of our releases.

Just above this, we exit if the OS isn't RHEL 8.[0-6]. This code very intentionally will not run on RHEL9, because we don't need it there.

travier · 2022-08-29T17:45:32Z

/lgtm cancel

travier · 2022-08-29T17:49:52Z

OK, I've verified that it is .31 on 4.8 so that's good enough.
/lgtm

openshift-ci-robot · 2022-08-29T18:35:47Z

/retest-required

Remaining retests: 2 against base HEAD e6acd9f and 8 for PR HEAD 87e93c2 in total

openshift-ci-robot · 2022-08-29T19:35:49Z

/retest-required

Remaining retests: 1 against base HEAD e6acd9f and 7 for PR HEAD 87e93c2 in total

cgwalters · 2022-08-29T20:21:15Z

/skip

openshift-ci-robot · 2022-08-30T00:35:34Z

/retest-required

Remaining retests: 1 against base HEAD 31132b4 and 7 for PR HEAD c43686d in total

openshift-ci-robot · 2022-08-30T01:35:40Z

/retest-required

Remaining retests: 0 against base HEAD 31132b4 and 6 for PR HEAD c43686d in total

openshift-ci-robot · 2022-08-30T05:35:35Z

/retest-required

Remaining retests: 2 against base HEAD 123b70c and 5 for PR HEAD c43686d in total

openshift-ci-robot · 2022-08-30T06:35:30Z

/retest-required

Remaining retests: 1 against base HEAD 123b70c and 4 for PR HEAD c43686d in total

openshift-ci-robot · 2022-08-30T07:35:38Z

/retest-required

Remaining retests: 0 against base HEAD 123b70c and 3 for PR HEAD c43686d in total

cgwalters · 2022-08-30T11:57:12Z

Hmm I swear I pushed a fix for the case of c9s yesterday, but not seeing it here. Anyways I just changed it to use ${RHEL_VERSION:-} consistently so we don't error out if it's unset.

cgwalters · 2022-08-30T12:04:30Z

Ahh I did push that attempted change but to the test code, not the core logic 🤦 - they're both similar looking shell scripts. Fixed.

This will auto rebuild the policy if we detect local modifications; it is only needed before RHEL 8.7 when we'll pick up the combined underlying work from https://bugzilla.redhat.com/show_bug.cgi?id=2057497

travier · 2022-08-30T13:23:54Z

Wrote commit: 193b3ec7eef58756c1ba2577e236bd7deb07ba034a1613fb74f41f642a49d031
mv: cannot move 'cache/output.tar' to '/tmp/cosa/tmp/repo/commit.tar': Cannot allocate memory

We might need to request more memory for this pod?

cgwalters · 2022-08-30T13:26:11Z

We might need to request more memory for this pod?

That looks like another instance of coreos/coreos-assembler#2940 (comment) - more memory won't help, it's a 9p bug.

cgwalters · 2022-08-30T13:27:25Z

/retest

travier

/lgtm

openshift-ci · 2022-08-30T14:16:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jmarrero, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cgwalters,jmarrero,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

travier · 2022-08-30T16:39:44Z

Failed at the 3h mark due to timeout.

travier · 2022-08-30T16:41:39Z

/test ci/prow/rhcos-86-build-test-qemu

openshift-ci · 2022-08-30T16:41:52Z

@travier: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test images
/test periodic-images
/test rhcos-86-build-test-metal
/test rhcos-86-build-test-qemu
/test rhcos-90-build-test-metal
/test rhcos-90-build-test-qemu
/test scos-9-build-test-metal
/test scos-9-build-test-qemu
/test validate

Use /test all to run all jobs.

Details

In response to this:

/test ci/prow/rhcos-86-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

travier · 2022-08-30T16:42:08Z

/test rhcos-86-build-test-qemu

openshift-ci · 2022-08-30T19:15:44Z

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-08-30T19:19:14Z

@cgwalters: All pull requests linked via external trackers have merged:

openshift/os#962

Jira Issue OCPBUGS-595 has been moved to the MODIFIED state.

Details

In response to this:

This will auto rebuild the policy if we detect local modifications;
it is only needed before RHEL 8.7 when we'll pick up the
combined underlying work from
https://bugzilla.redhat.com/show_bug.cgi?id=2057497

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cgwalters · 2022-08-30T21:04:43Z

/cherrypick release-4.11

openshift-cherrypick-robot · 2022-08-30T21:05:21Z

@cgwalters: new pull request created: #966

Details

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2022

cgwalters changed the title ~~overlay: Add rhcos-selinux-policy-upgrade.service~~ OCPBUGS-595: overlay: Add rhcos-selinux-policy-upgrade.service Aug 29, 2022

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Aug 29, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 29, 2022

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022

openshift-ci Bot requested a review from mike-nguyen August 29, 2022 14:01

travier approved these changes Aug 29, 2022

View reviewed changes

cgwalters force-pushed the auto-rebuild-policy branch from b1fd097 to 87e93c2 Compare August 29, 2022 17:16

cgwalters marked this pull request as ready for review August 29, 2022 17:17

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2022

openshift-ci Bot requested review from RishabhSaini and jmarrero August 29, 2022 17:22

travier reviewed Aug 29, 2022

View reviewed changes

openshift-ci Bot assigned travier Aug 29, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022

cgwalters force-pushed the auto-rebuild-policy branch from c43686d to 95807f3 Compare August 30, 2022 11:56

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022

cgwalters force-pushed the auto-rebuild-policy branch from 95807f3 to 76ccbe2 Compare August 30, 2022 12:03

overlay: Add rhcos-selinux-policy-upgrade.service

e974146

This will auto rebuild the policy if we detect local modifications; it is only needed before RHEL 8.7 when we'll pick up the combined underlying work from https://bugzilla.redhat.com/show_bug.cgi?id=2057497

cgwalters force-pushed the auto-rebuild-policy branch from 76ccbe2 to e974146 Compare August 30, 2022 12:04

travier approved these changes Aug 30, 2022

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2022

openshift-merge-robot merged commit ecef30e into openshift:master Aug 30, 2022

openshift-cherrypick-robot mentioned this pull request Aug 30, 2022

[release-4.11] OCPBUGS-727: overlay: Add rhcos-selinux-policy-upgrade.service #966

Merged

LorbusChris mentioned this pull request Sep 13, 2022

OKD update from 4.10 to 4.11 failed due to permission issue for NetworkManager-dispatcher scripts for VMXNET3 VxLAN offload bug okd-project/okd#1317

Closed

lucab mentioned this pull request Oct 26, 2022

RHCOS 8.6 failing on ext.config.rebuild-selinux-policy #1036

Closed

Conversation

cgwalters commented Aug 29, 2022

Uh oh!

openshift-ci Bot commented Aug 29, 2022

Uh oh!

openshift-ci-robot commented Aug 29, 2022

Uh oh!

cgwalters commented Aug 29, 2022

Uh oh!

openshift-ci-robot commented Aug 29, 2022

Uh oh!

cgwalters commented Aug 29, 2022

Uh oh!

openshift-ci-robot commented Aug 29, 2022

Uh oh!

cgwalters commented Aug 29, 2022

Uh oh!

travier Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

cgwalters Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

travier commented Aug 29, 2022

Uh oh!

travier commented Aug 29, 2022

Uh oh!

openshift-ci-robot commented Aug 29, 2022

Uh oh!

openshift-ci-robot commented Aug 29, 2022

Uh oh!

cgwalters commented Aug 29, 2022

Uh oh!

openshift-ci-robot commented Aug 30, 2022

Uh oh!

openshift-ci-robot commented Aug 30, 2022

Uh oh!

openshift-ci-robot commented Aug 30, 2022

Uh oh!

openshift-ci-robot commented Aug 30, 2022

Uh oh!

openshift-ci-robot commented Aug 30, 2022

Uh oh!

cgwalters commented Aug 30, 2022

Uh oh!

cgwalters commented Aug 30, 2022

Uh oh!

travier commented Aug 30, 2022

Uh oh!

cgwalters commented Aug 30, 2022

Uh oh!

cgwalters commented Aug 30, 2022

Uh oh!

travier left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 30, 2022

Uh oh!

travier commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

travier commented Aug 30, 2022

Uh oh!

openshift-ci Bot commented Aug 30, 2022

Uh oh!

travier commented Aug 30, 2022

Uh oh!

openshift-ci Bot commented Aug 30, 2022

Uh oh!

openshift-ci-robot commented Aug 30, 2022

Uh oh!

cgwalters commented Aug 30, 2022

Uh oh!

openshift-cherrypick-robot commented Aug 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

travier commented Aug 30, 2022 •

edited

Loading