Skip to content

[release-4.10] OCPBUGS-856: overlay: Add rhcos-selinux-policy-upgrade.service#973

Closed
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.10from
openshift-cherrypick-robot:cherry-pick-966-to-release-4.10
Closed

[release-4.10] OCPBUGS-856: overlay: Add rhcos-selinux-policy-upgrade.service#973
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.10from
openshift-cherrypick-robot:cherry-pick-966-to-release-4.10

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 2, 2022

This is an automated cherry-pick of #966

/assign travier

@cgwalters
overlay: Add rhcos-selinux-policy-upgrade.service
cec615d 
This will auto rebuild the policy if we detect local modifications;
it is only needed before RHEL 8.7 when we'll pick up the
combined underlying work from
https://bugzilla.redhat.com/show_bug.cgi?id=2057497
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 2, 2022
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 2, 2022

@openshift-cherrypick-robot: Jira Issue OCPBUGS-727 has been cloned as Jira Issue OCPBUGS-856. Retitling PR to link against new bug.
/retitle [release-4.10] OCPBUGS-856: overlay: Add rhcos-selinux-policy-upgrade.service

Details

In response to this:

This is an automated cherry-pick of #966

/assign travier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.10] OCPBUGS-727: overlay: Add rhcos-selinux-policy-upgrade.service [release-4.10] OCPBUGS-856: overlay: Add rhcos-selinux-policy-upgrade.service Sep 2, 2022
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Sep 2, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 2, 2022

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-856, which is invalid:

  • expected dependent Jira Issue OCPBUGS-727 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This is an automated cherry-pick of #966

/assign travier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 2, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.10] OCPBUGS-856: overlay: Add rhcos-selinux-policy-upgrade.service

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign jmarrero for approval by writing /assign @jmarrero in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Copy Markdown
Member

travier commented Sep 2, 2022

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2022

@travier: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Copy Markdown
Member

travier commented Sep 2, 2022

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 2, 2022

@travier: This pull request references Jira Issue OCPBUGS-856, which is invalid:

  • expected dependent Jira Issue OCPBUGS-727 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 2, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images cec615d link true /test images
ci/prow/validate cec615d link true /test validate
ci/prow/build-test-qemu cec615d link true /test build-test-qemu

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Copy Markdown
Member

wking commented Sep 2, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 2, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 2, 2022

@wking: This pull request references Jira Issue OCPBUGS-856, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-727 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE))
  • dependent Jira Issue OCPBUGS-727 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 2, 2022
@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Sep 6, 2022

It's not clear to me that we strictly need this on 4.10 - it will potentially solve some problem cases, but on the other hand we have verification that the fix that landed in 4.11.z is sufficient to address the KubeVirt case.
So
/hold
unless we have evidence that this is needed - i.e. we have a customer case that reproduces a problem.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Sep 12, 2022

Closing based on the above.

@cgwalters cgwalters closed this Sep 12, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 12, 2022

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-856. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

This is an automated cherry-pick of #966

/assign travier

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dustymabe dustymabe Awaiting requested review from dustymabe

@saqibali-2k saqibali-2k Awaiting requested review from saqibali-2k

Assignees

@travier travier

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @travier @wking @cgwalters