[SDCICD-1729] Enable native osde2e S3 upload for test artifacts#519
[SDCICD-1729] Enable native osde2e S3 upload for test artifacts#519YiqinZhang wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
/hold for openshift/osde2e#3089 |
|
/unhold |
4776335 to
f845fa7
Compare
|
@YiqinZhang: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| required: true | ||
| - name: LOG_BUCKET | ||
| value: 'osde2e-logs' | ||
| value: 'osde2e-loki-logs' |
There was a problem hiding this comment.
what's the difference between these 2 buckets? are they in different accounts?
There was a problem hiding this comment.
No big difference. osde2e-loki-logs is the existing bucket , using it just avoids creating a new one.
There was a problem hiding this comment.
osde2e-logs is an existing bucket as well, specified in all PD pipelines.
There was a problem hiding this comment.
I suggest comparing this with boilerplate template and minimizing any non-necessary changes, as these will need to be updated in all PD pipelines
Configure e2e-template.yml to use native osde2e S3 upload for test artifacts instead of a sidecar container approach.
Removed
S3_UPLOAD_*variables)Simplified
LOG_BUCKETparameter enables native S3 uploadTEST_SUITES_YAMLimagetest-results/<component>/<date>/<job-id>/AWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY)Configuration
osde2e automatically handles S3 upload when
LOG_BUCKETis set:LOG_BUCKETosde2e-loki-logsAWS_ACCESS_KEY_IDAWS_SECRET_ACCESS_KEYosd-example-operatorTEST_SUITES_YAMLus-east-1S3 Path Structure
Artifacts are automatically organized:
SDCICD-1729