Skip to content

Conversation

@MateSaary
Copy link
Member

@MateSaary MateSaary commented May 13, 2025

This minor PR improves the misleading "outdated" message returned if the command is unable to access Gitlab to obtain the expected version of the operator. The PR also updates the GitLab client to client-go as go-gitlab has been deprecated.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2025

@MateSaary: This pull request references OSD-29994 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This minor PR fixes the misleading "outdated" message returned if the command is unable to access Gitlab to obtain the expected version of the operator. The PR also updates the GitLab client to client-go as go-gitlab has been deprecated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 13, 2025
@openshift-ci openshift-ci bot requested review from joshbranham and typeid May 13, 2025 20:46
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2025

@MateSaary: This pull request references OSD-29994 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This minor PR improves the misleading "outdated" message returned if the command is unable to access Gitlab to obtain the expected version of the operator. The PR also updates the GitLab client to client-go as go-gitlab has been deprecated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MateSaary MateSaary changed the title OSD-29994: Fix sre-operators command misleading message OSD-29994: Improve sre-operators command misleading message May 13, 2025
@MateSaary MateSaary force-pushed the OSD-29994-sre-operators-message branch from ef5c11a to 05468ab Compare May 14, 2025 08:17
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2025

@MateSaary: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, MateSaary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 730f560 into openshift:master May 14, 2025
6 checks passed
@MateSaary MateSaary deleted the OSD-29994-sre-operators-message branch May 14, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants