OSD-30081: Fix issues with osdctl promote saas
#750
Conversation
In openshift#723 a refactor was done to make testing easier for this package. However, it turns out that was not tested functionally and there were a few issues. This fixes those issues.
openshift-ci
bot
added
the
approved
joshbranham
changed the title
osdctl promote saasosdctl promote saas
openshift-ci-robot
added
the
jira/valid-reference
|
@joshbranham: This pull request references OSD-30081 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@joshbranham: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| } | ||
|
|
||
| /* | ||
| // Not in use |
There was a problem hiding this comment.
Unsure why this was commented out as "not in use" versus just being removed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshbranham, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Btw, I ran this locally with the fixes and it produced a valid branch and pushed it 👍 |
3 participants
In #723 a refactor was done to make testing easier for this package. However, it turns out that was not tested functionally and there were a few issues. This fixes those issues.