Skip to content

Conversation

@joshbranham
Copy link
Contributor

Switch to using our base boilerplate image in CI, which provides the benefit of ensuring common tools like golangci-lint are installed.

Needed to resolve openshift/release#64870

Switch to using our base boilerplate image in CI, which provides the benefit
of ensuring common tools like `golangci-lint` are installed.

Needed to resolve openshift/release#64870
@joshbranham joshbranham self-assigned this May 14, 2025
@joshbranham joshbranham changed the title Use our boilerplate base image in CI SREP-325: Use our boilerplate base image in CI May 14, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2025

@joshbranham: This pull request references SREP-325 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Switch to using our base boilerplate image in CI, which provides the benefit of ensuring common tools like golangci-lint are installed.

Needed to resolve openshift/release#64870

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from devppratik and fahlmant May 14, 2025 17:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2025

@joshbranham: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dustman9000,joshbranham]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bb52ec6 into openshift:master May 14, 2025
6 checks passed
@joshbranham joshbranham deleted the use-boilerplate-ci-base-image branch May 14, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants