Skip to content

Conversation

@typeid
Copy link
Member

@typeid typeid commented May 22, 2025

The promotions for saas-osd-rhobs-rules-and-dashboards failed because we're looking in the wrong place for the current hash.

osdctl promote saas --serviceName saas-osd-rhobs-rules-and-dashboards --osd
### Checking if service saas-osd-rhobs-rules-and-dashboards exists ###
Service saas-osd-rhobs-rules-and-dashboards found
SAAS Directory: /home/cbusse/sandbox/app-interface/data/services/osd-operators/cicd/saas/saas-osd-rhobs-rules-and-dashboards.yaml
Error while promoting service: failed to get current git hash or service repo: production namespace not found for service saas-osd-rhobs-rules-and-dashboards

This PR fixes the logic to find the hash in the right place.

A successful promotion has been created with this build.

@openshift-ci openshift-ci bot requested review from devppratik and joshbranham May 22, 2025 06:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2025

@typeid: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a72ef9 into openshift:master May 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants