-
Notifications
You must be signed in to change notification settings - Fork 133
OSD-28506: feat(Add Handover Announcements to Cluster Context Command) #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD-28506: feat(Add Handover Announcements to Cluster Context Command) #764
Conversation
|
@devppratik: This pull request references OSD-28506 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
89feda0 to
0bb570f
Compare
|
@devppratik I have started testing your changes and noticed that cluster context does not show the announcement for staging cluster |
0bb570f to
cc6a161
Compare
Improve search logic for Handover Announcements Fix minor issues Fix Lint Fix Lint Add logic to print unique announcements Fix validMatch logic
cc6a161 to
dfc4b75
Compare
|
Thank you @devppratik for the MR. When testing, have noticed that cluster context command is returning same announcement twice when the announcment is for the cluster id and may be the version. We might need to remove duplicates in the list before we print the results of the JIRA query. |
|
@devppratik: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@chamalabey It has been fixed. Please review again |
|
@devppratik Have tested and new changes looks good. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chamalabey, devppratik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
joshbranham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you come back and add some tests for these new changes?
|
@joshbranham Sure I can add some test cases, but the jira.go file would need to be refactored to make it mockable and testable. Will take up in a separate PR |
We are looking to migrate from the Handover Doc to a JIRA based Handover Board. This would allow to use JIRA queries to directly display related handover announcements at the time of login for the cluster based on ID, Customer Name, Version and Product.
This PR adds the functionality to query JIRA and print the related announcements for the cluster.
Related Issue OSD-28505