Add a RPM spec file #779
Add a RPM spec file #779
Conversation
This takes a bunch of shortcuts to make it work: - It does simply use go modules to download the dependencies during build time, instead of package every dependency. - It skips the %check sections, as that flagged some additional issues that our CI didn't catch.
openshift-ci
bot
added
the
approved
|
Maybe not related to what you're doing, but long term I would suggest using goreleaser in GitHub Actions to release the project on tags 👌 |
|
I think the goreleaser route might be useful for Mac OS (and providing binaries for whoever does not want to use COPR) - my main goal of using a COPR flow would be allowing users to use their normal DNF to keep our tools up-to-date without needing to do it themselves or some other extra tool. |
|
I've added a github action to trigger the COPR build now as well - I decided to keep the COPR_URL as a secret, so not everyone can just trigger builds. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bergmannf, RaphaelBut The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bergmannf: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This PR adds a spec file to the repository that can be used with a webhook in COPR to automatically build a new version of osdctl on tag pushes.
The spec file and shell-script are mostly for reference, as the shell-script actually needs to be added to the custom build in COPR to actually prepare the spec file to have the correct version information during buildtime.