TEST ONLY: chore(kubernetes): deduplicate warning logs from the API #285
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machine424 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@machine424: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
looking at prometheus logs on |
| } | ||
|
|
||
| // dedupWarningHandler allows to deduplicate API warnings by message. | ||
| // Inspired from https://github.com/kubernetes/kubernetes/blob/3edae6c1c49958fd10a708d9cc8c4c9e7f5fb6e8/staging/src/k8s.io/client-go/rest/warnings.go#L113 |
| } | ||
|
|
||
| w.logged[message] = struct{}{} | ||
| klogv2.FromContext(ctx).Info("Warning: " + message) |
There was a problem hiding this comment.
just call the default's if possible
1 participant
No description provided.