Skip to content

Dockerfile.ocp: upgrade Go to 1.13 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jan 3, 2020
Merged

Dockerfile.ocp: upgrade Go to 1.13 #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile.ocp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.svc.ci.openshift.org/openshift/release:golang-1.12 AS builder
FROM registry.svc.ci.openshift.org/openshift/release:golang-1.13 AS builder
WORKDIR /go/src/github.com/prometheus/prometheus
COPY . .
# NOTE(spasquie): the 'build' target regenerates the ReactJS code and the Go
Expand All @@ -14,7 +14,7 @@ LABEL io.k8s.display-name="OpenShift Prometheus" \
io.k8s.description="The Prometheus monitoring system and time series database." \
io.openshift.tags="prometheus,monitoring" \
maintainer="OpenShift Development <dev@lists.openshift.redhat.com>" \
version="v2.10.0"
version="v2.14.0"
Copy link

@pgier pgier Jan 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I guess this was missed in the last upgrade.

Copy link
Author

@simonpasquier simonpasquier Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't think it matters that much TBH.


ARG FROM_DIRECTORY=/go/src/github.com/prometheus/prometheus
COPY --from=builder ${FROM_DIRECTORY}/prometheus /bin/prometheus
Expand Down