ci-operator/step-registry/openshift/e2e/gcp/crc: Include "gcp" in workflow name #10389
Conversation
wking
force-pushed
the
openshift-e2e-gcp-crc
branch
2 times, most recently
from
03e9f53 to
28c215a
Compare
|
/assign @stevekuznetsov |
wking
force-pushed
the
openshift-e2e-gcp-crc
branch
from
28c215a to
6bd823d
Compare
openshift-ci-robot
added
the
approved
|
Dropped the openshift-priv changes with 28c215a7b8 -> 6bd823da9e; @alvaroaleman points out that they're auto-generated. Now I'm a full approver, and we just need a /assign @praveenkumar |
can you explain what you mean by it's GCP workflow? GCP workflow for openshift? Or that CRC is building their CI on GCP platform. |
Just that it uses a GCP-based workflow and cluster profile and so consumes GCP Boskos leases. Although if it's just running a single, fat GCP machine and then using libvirt locally, it means our GCP Boskos lease pool is assigning the same lease for real GCP clusters as it is for these fat-instance libvirt clusters that lack much of the rest of the real GCP cluster resources. Also potentially in this space is openshift/installer#3812. |
I'm not changing the job name, which is sometimes used for aggregating CI statistics. I'm just adjusting the workflow name. |
openshift-ci-robot
added
the
needs-rebase
wking
force-pushed
the
openshift-e2e-gcp-crc
branch
from
6bd823d to
92ac811
Compare
openshift-ci-robot
removed
the
needs-rebase
|
Rebased onto master with 6bd823da9e -> 92ac81133a |
openshift-ci-robot
removed
the
approved
|
Needs rebase, but otherwise |
wking
force-pushed
the
openshift-e2e-gcp-crc
branch
from
92ac811 to
b60c2eb
Compare
openshift-ci-robot
added
approved
|
Rebased around #11821 with 92ac81133a -> b60c2eb35e. |
…kflow name
It's a GCP workflow, and we might grow additional workflows for other
platforms in the future. Including the platform in the workflow name
makes space for that, and avoids:
$ hack/step-jobs-by-platform.py
unable to determine platform-agnostic workflows for:
openshift-e2e-crc
gcp (pull-ci-openshift-installer-master-e2e-crc, pull-ci-openshift-installer-release-4.6-e2e-crc, pull-ci-openshift-installer-release-4.7-e2e-crc)
...
Leaving ci-operator/config/openshift-priv alone, because those will be
auto-updated at some point after the ci-operator/config/openshift
changes land, as seen in [1].
*.metadata.json updated via:
$ make update
[1]: openshift#10382
wking
force-pushed
the
openshift-e2e-gcp-crc
branch
from
b60c2eb to
e2e4000
Compare
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtnbikenc, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the following 5 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
It's a GCP workflow, and we might grow additional workflows for other platforms in the future. Including the platform in the workflow name makes space for that, and avoids:
For precedent, see #10165.