Ignition spec 3 update for cluster-launch-installer-upi-e2e by travier · Pull Request #10534 · openshift/release

travier · 2020-07-29T12:25:55Z

This is required starting with RHCOS 4.6.

runcom · 2020-07-29T12:27:33Z

travier · 2020-07-29T12:30:55Z

Please be aware that I have just performed the Ignition config conversion and I do not know the full implication this has on the CI (if this may break older non spec 3 jobs, etc.).

travier · 2020-07-29T12:32:33Z

This may also probably require a split into multiple PRs.

LorbusChris · 2020-07-29T12:51:04Z

@travier any reason not go with spec 3.1.0? Installer will be using that everywhere.

cgwalters · 2020-07-29T12:53:19Z

Right, we can't just mass convert because many of these configs are part of templates/steps which get reused for older branches too.

cgwalters · 2020-07-29T12:54:18Z

Perhaps the simplest thing is to check whether the target release is ≥ 4.6 and if so, download and use ign-convert to upconvert from spec2x.

travier · 2020-07-29T12:58:06Z

@travier any reason not go with spec 3.1.0? Installer will be using that everywhere.

No reason, will update.

travier · 2020-07-29T12:59:11Z

Perhaps the simplest thing is to check whether the target release is ≥ 4.6 and if so, download and use ign-convert to upconvert from spec2x.

I would say do the reverse? Down-convert from spec 3 when needed? Will try to look into that.

travier · 2020-07-29T13:06:42Z

This still requires a check for cluster version. Marking as draft.

LorbusChris · 2020-08-11T19:22:32Z

I think all the empty fields can be dropped entirely from the json with spec 3

LorbusChris · 2020-09-23T16:20:27Z

Looks like this has been fixed?

travier · 2020-09-24T10:14:29Z

The aws/proxy case has been ported to Fedora CoreOS thus to spec 3. The cluster-launch-installer-upi-e2e hasn't been updated yet. Updated with only this one.

openshift-ci-robot · 2020-09-24T11:47:06Z

@travier: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/installer/master/e2e-aws-proxy	4e601e006b8461164c48000f370133775642bb14	link	`/test pj-rehearse`
ci/prow/ci-testgrid-allow-list	4e601e006b8461164c48000f370133775642bb14	link	`/test ci-testgrid-allow-list`
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere	dbf8f32421eba061f78041593744e4b2a23ac0f8	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/master/e2e-aws-upi	dbf8f32421eba061f78041593744e4b2a23ac0f8	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/master/e2e-azure-upi	dbf8f32421eba061f78041593744e4b2a23ac0f8	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/release-4.3/e2e-gcp-upi	dbf8f32421eba061f78041593744e4b2a23ac0f8	link	`/test pj-rehearse`
ci/prow/pj-rehearse	dbf8f32421eba061f78041593744e4b2a23ac0f8	link	`/test pj-rehearse`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2020-10-30T20:28:09Z

@travier: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/secret-generator-config-valid	dbf8f32421eba061f78041593744e4b2a23ac0f8	link	`/test secret-generator-config-valid`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-02-09T01:55:51Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2021-03-11T02:13:22Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

travier · 2021-03-11T18:05:01Z

/remove-lifecycle rotten

openshift-ci-robot · 2021-03-11T18:14:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: travier
To complete the pull request process, please assign mandre after the PR has been reviewed.
You can assign the PR to them by writing /assign @mandre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

ci-operator/templates/openshift/installer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This is required starting with RHCOS 4.6.

openshift-ci · 2021-06-08T09:15:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: travier
To complete the pull request process, please assign mandre after the PR has been reviewed.
You can assign the PR to them by writing /assign @mandre in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

ci-operator/templates/openshift/installer/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LorbusChris · 2021-06-08T14:17:45Z

        {
          "ignition": {
-            "config": {},
+            "config": {


Nit: I think all the empty fields can be dropped here as ignition uses a parser implementation that allows for that

Other than that, I think this change should go in

jhixson74 · 2021-07-08T01:23:16Z

/uncc

openshift-ci · 2021-08-09T20:49:59Z

@travier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required
ci/rehearse/openshift/installer/master/e2e-aws-upi	`24e6e6c`	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/master/e2e-azure-upi	`24e6e6c`	link	`/test pj-rehearse`
ci/prow/pj-rehearse	`24e6e6c`	link	`/test pj-rehearse`
ci/prow/openshift-image-mirror-mappings	`24e6e6c`	link	`/test openshift-image-mirror-mappings`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-12-27T14:59:28Z

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2022-01-11T15:04:52Z

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2022-02-18T09:42:14Z

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2022-02-18T09:42:47Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from jhixson74 and patrickdillon July 29, 2020 12:26

travier mentioned this pull request Jul 29, 2020

Migrate to Ignition config spec v3.1 and bump RHCOS openshift/installer#3871

Merged

cgwalters reviewed Jul 29, 2020

View reviewed changes

Comment thread clusters/build-clusters/01_cluster/machine_config/99-debug-ssh.yaml Outdated

travier force-pushed the ign3 branch from b13193f to 4e601e0 Compare July 29, 2020 13:05

travier changed the title ~~Ignition spec 3.0.0 related updates~~ WIP: Ignition spec 3.0.0 related updates Jul 29, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2020

travier force-pushed the ign3 branch 2 times, most recently from 2d6bcfd to dbf8f32 Compare September 24, 2020 10:14

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2021

openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 11, 2021

openshift-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 11, 2021

travier force-pushed the ign3 branch from dbf8f32 to 1642f5c Compare March 11, 2021 18:14

travier changed the title ~~WIP: Ignition spec 3.0.0 related updates~~ Ignition spec 3.0.0 update for cluster-launch-installer-upi-e2e Mar 11, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2021

travier changed the title ~~Ignition spec 3.0.0 update for cluster-launch-installer-upi-e2e~~ Ignition spec 3 update for cluster-launch-installer-upi-e2e Mar 11, 2021

ci-operator/templates/upi/proxy: Convert to Ignition spec 3.1.0

24e6e6c

This is required starting with RHCOS 4.6.

travier force-pushed the ign3 branch from 1642f5c to 24e6e6c Compare June 8, 2021 09:15

LorbusChris reviewed Jun 8, 2021

View reviewed changes

openshift-ci Bot removed the request for review from jhixson74 July 8, 2021 01:23

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2021

openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 11, 2022

openshift-ci Bot closed this Feb 18, 2022

Conversation

travier commented Jul 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

runcom commented Jul 29, 2020

Uh oh!

travier commented Jul 29, 2020

Uh oh!

travier commented Jul 29, 2020

Uh oh!

LorbusChris commented Jul 29, 2020

Uh oh!

cgwalters commented Jul 29, 2020

Uh oh!

cgwalters commented Jul 29, 2020

Uh oh!

travier commented Jul 29, 2020

Uh oh!

Uh oh!

travier commented Jul 29, 2020

Uh oh!

travier commented Jul 29, 2020

Uh oh!

LorbusChris commented Aug 11, 2020

Uh oh!

LorbusChris commented Sep 23, 2020

Uh oh!

travier commented Sep 24, 2020

Uh oh!

openshift-ci-robot commented Sep 24, 2020

Uh oh!

openshift-merge-robot commented Oct 30, 2020

Uh oh!

openshift-bot commented Feb 9, 2021

Uh oh!

openshift-bot commented Mar 11, 2021

Uh oh!

travier commented Mar 11, 2021

Uh oh!

openshift-ci-robot commented Mar 11, 2021

Uh oh!

openshift-ci Bot commented Jun 8, 2021

Uh oh!

LorbusChris Jun 8, 2021

Choose a reason for hiding this comment

Uh oh!

jhixson74 commented Jul 8, 2021

Uh oh!

openshift-ci Bot commented Aug 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Dec 27, 2021

Uh oh!

openshift-bot commented Jan 11, 2022

Uh oh!

openshift-bot commented Feb 18, 2022

Uh oh!

openshift-ci Bot commented Feb 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

travier commented Jul 29, 2020 •

edited

Loading

openshift-ci Bot commented Aug 9, 2021 •

edited

Loading