Skip to content

Allow a dev-scripts PR to test configuration change#11178

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
andfasano:baremetalds-conf-pr
Aug 25, 2020
Merged

Allow a dev-scripts PR to test configuration change#11178
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
andfasano:baremetalds-conf-pr

Conversation

@andfasano
Copy link
Copy Markdown
Contributor

This PR is meant to provide support for testing a PR that requires a dev-scripts configuration change. Currently this is not possible, and this means that every time a developer proposes a PR for dev-scripts repo containing new code activated by a configuration change the CI does not exercise it.

With this PR, a developer can now temporarily add the dev-scripts-additional-config file in his/her own PR with the required configuration settings and test it.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@stbenjam
Copy link
Copy Markdown
Member

Usually I just dump the new config into common.sh or something, this seems a bit nicer.

@andfasano
Copy link
Copy Markdown
Contributor Author

/test pj-rehearse

1 similar comment
@andfasano
Copy link
Copy Markdown
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Copy Markdown
Contributor Author

Usually I just dump the new config into common.sh or something, this seems a bit nicer.

This change could help PRs like openshift-metal3/dev-scripts#1084

@andfasano
Copy link
Copy Markdown
Contributor Author

/test pj-rehearse

@stbenjam
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andfasano andfasano changed the title [WIP] Allow a dev-scripts PR to test configuration change Allow a dev-scripts PR to test configuration change Aug 25, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 25, 2020

@andfasano: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift-metal3/dev-scripts/master/e2e-metal-ipi-dualstack acb9175 link /test pj-rehearse
ci/prow/pj-rehearse acb9175 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andfasano
Copy link
Copy Markdown
Contributor Author

/test core-valid

@openshift-merge-robot openshift-merge-robot merged commit e08526e into openshift:master Aug 25, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@andfasano: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key baremetalds-devscripts-setup-commands.sh using file ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key baremetalds-devscripts-setup-commands.sh using file ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
Details

In response to this:

This PR is meant to provide support for testing a PR that requires a dev-scripts configuration change. Currently this is not possible, and this means that every time a developer proposes a PR for dev-scripts repo containing new code activated by a configuration change the CI does not exercise it.

With this PR, a developer can now temporarily add the dev-scripts-additional-config file in his/her own PR with the required configuration settings and test it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants