Allow a dev-scripts PR to test configuration change#11178
Allow a dev-scripts PR to test configuration change#11178openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
Usually I just dump the new config into common.sh or something, this seems a bit nicer. |
|
/test pj-rehearse |
1 similar comment
|
/test pj-rehearse |
This change could help PRs like openshift-metal3/dev-scripts#1084 |
|
/test pj-rehearse |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test core-valid |
|
@andfasano: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is meant to provide support for testing a PR that requires a dev-scripts configuration change. Currently this is not possible, and this means that every time a developer proposes a PR for dev-scripts repo containing new code activated by a configuration change the CI does not exercise it.
With this PR, a developer can now temporarily add the
dev-scripts-additional-configfile in his/her own PR with the required configuration settings and test it.