Skip to content

templates/installer: fix heredoc redirection#11313

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
crawford:libvirt-heredoc
Aug 28, 2020
Merged

templates/installer: fix heredoc redirection#11313
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
crawford:libvirt-heredoc

Conversation

@crawford
Copy link
Copy Markdown
Contributor

If any part of word is quoted, the delimiter is the result of quote
removal on word, and the lines in the here-document are not expanded.

http://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Here-Documents

This is an alternate approach to the one found in #11303 (cc @sallyom).

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
> If any part of word is quoted, the delimiter is the result of quote
> removal on word, and the lines in the here-document are not expanded.

http://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Here-Documents
@sallyom
Copy link
Copy Markdown
Contributor

sallyom commented Aug 28, 2020

/lgtm

thanks @crawford

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit aac7e2f into openshift:master Aug 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@crawford: Updated the following 4 configmaps:

  • prow-job-cluster-launch-installer-libvirt-e2e configmap in namespace ci at cluster app.ci using the following files:
    • key cluster-launch-installer-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
  • prow-job-cluster-launch-installer-libvirt-e2e configmap in namespace ci at cluster build01 using the following files:
    • key cluster-launch-installer-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
  • prow-job-cluster-launch-installer-libvirt-e2e configmap in namespace ci at cluster build02 using the following files:
    • key cluster-launch-installer-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
  • prow-job-cluster-launch-installer-libvirt-e2e configmap in namespace ci at cluster api.ci using the following files:
    • key cluster-launch-installer-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
Details

In response to this:

If any part of word is quoted, the delimiter is the result of quote
removal on word, and the lines in the here-document are not expanded.

http://www.gnu.org/savannah-checkouts/gnu/bash/manual/bash.html#Here-Documents

This is an alternate approach to the one found in #11303 (cc @sallyom).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford crawford deleted the libvirt-heredoc branch August 28, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants