Bug 1874252: pinning image to rhcos 4.5 for step registry proxy config#11453
Conversation
4606471 to
6a5e180
Compare
941b370 to
623c40a
Compare
|
@ewolinetz: This pull request references Bugzilla bug 1874252, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@ewolinetz: This pull request references Bugzilla bug 1874252, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm The job at least run, so it is a progress :-) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest I would merge this regardless of what the rehearse say? |
|
@mfojtik rehearse isn't a blocker for this to merge. the cluster is able to install correctly with this change, if a test fails it would be due to a component given this passes on 4.5 |
|
@ewolinetz can you summarize why we need 4.5 in 4.6 test? is this CI only or will any customer installing 4.6 behind proxy have to go over this problem? |
|
/hold |
|
/hold cancel This is just about our CI setup, it has nothing to do with in-product proxy support. |
|
/hold |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Looking at the previous, failed proxy rehearsal, I'm not clear on why we still failed to SSH into the proxy instance. Proxy console logs look ok to me. |
|
/hold cancel moves the ball forward, but more work is needed |
|
@ewolinetz: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ewolinetz: All pull requests linked via external trackers have merged: Bugzilla bug 1874252 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pinning to RHCOS 4.5 due to 4.6's pivot to using ignition v3.1.0 (which doesn't work with 4.5 and older) re: openshift/installer#3871
Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1874252