Skip to content

Bug 1874252: pinning image to rhcos 4.5 for step registry proxy config#11453

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ewolinetz:debug_proxy_failing
Sep 1, 2020
Merged

Bug 1874252: pinning image to rhcos 4.5 for step registry proxy config#11453
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ewolinetz:debug_proxy_failing

Conversation

@ewolinetz
Copy link
Copy Markdown
Contributor

@ewolinetz ewolinetz commented Aug 31, 2020

Pinning to RHCOS 4.5 due to 4.6's pivot to using ignition v3.1.0 (which doesn't work with 4.5 and older) re: openshift/installer#3871

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1874252

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 31, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@ewolinetz ewolinetz force-pushed the debug_proxy_failing branch from 4606471 to 6a5e180 Compare August 31, 2020 20:01
@ewolinetz ewolinetz changed the title [WIP] fixing proxy blackhole install Bug 1874252: pinning image to rhcos 4.5 for step registry proxy config Sep 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ewolinetz: This pull request references Bugzilla bug 1874252, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1874252: pinning image to rhcos 4.5 for step registry proxy config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 1, 2020
@ewolinetz
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 1, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ewolinetz: This pull request references Bugzilla bug 1874252, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 1, 2020
@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Sep 1, 2020

/lgtm

The job at least run, so it is a progress :-)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Sep 1, 2020

/retest

I would merge this regardless of what the rehearse say?

@ewolinetz
Copy link
Copy Markdown
Contributor Author

@mfojtik rehearse isn't a blocker for this to merge. the cluster is able to install correctly with this change, if a test fails it would be due to a component given this passes on 4.5

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Sep 1, 2020

@ewolinetz can you summarize why we need 4.5 in 4.6 test? is this CI only or will any customer installing 4.6 behind proxy have to go over this problem?

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Sep 1, 2020

/hold

@wking
Copy link
Copy Markdown
Member

wking commented Sep 1, 2020

/hold cancel

This is just about our CI setup, it has nothing to do with in-product proxy support.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@bparees
Copy link
Copy Markdown
Contributor

bparees commented Sep 1, 2020

/hold
rehearsal still failed

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@wking
Copy link
Copy Markdown
Member

wking commented Sep 1, 2020

Looking at the previous, failed proxy rehearsal, I'm not clear on why we still failed to SSH into the proxy instance. Proxy console logs look ok to me.

@bparees
Copy link
Copy Markdown
Contributor

bparees commented Sep 1, 2020

/hold cancel

moves the ball forward, but more work is needed

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit fec7b10 into openshift:master Sep 1, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ewolinetz: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key ipi-conf-aws-proxy-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key ipi-conf-aws-proxy-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml
Details

In response to this:

Pinning to RHCOS 4.5 due to 4.6's pivot to using ignition v3.1.0 (which doesn't work with 4.5 and older) re: openshift/installer#3871

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1874252

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@ewolinetz: All pull requests linked via external trackers have merged:

Bugzilla bug 1874252 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1874252: pinning image to rhcos 4.5 for step registry proxy config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants