Separating out proxy deprovision from gather to ensure tear down can occur

[ewolinetz]

Addresses current issue where proxy instances are being leaked due to failing to gather logs due to the proxy service not responding to ssh.

[wking]

Hmm, we must be pinning this because of the aws client? Looks like yes: openshift/installer#3292. Can we call that out in the commit message? And maybe drop the 4.5-pinning for gather-proxy-ref.yaml now that it no longer uses aws?

[wking]

/lgtm

Needs someone from DPTP to sign off because adding a new step and touching OWNERS now touches the metadata JSON file.

/assign @alvaroaleman

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, ewolinetz, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@ewolinetz: Updated the following 2 configmaps:

• step-registry configmap in namespace ci at cluster api.ci using the following files:
  • key gather-proxy-commands.sh using file ci-operator/step-registry/gather/proxy/gather-proxy-commands.sh
  • key gather-proxy-ref.yaml using file ci-operator/step-registry/gather/proxy/gather-proxy-ref.yaml
  • key ipi-aws-post-proxy-chain.yaml using file ci-operator/step-registry/ipi/aws/post/proxy/ipi-aws-post-proxy-chain.yaml
  • key OWNERS using file ci-operator/step-registry/ipi/deprovision/proxy/OWNERS
  • key ipi-deprovision-proxy-commands.sh using file ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-commands.sh
  • key ipi-deprovision-proxy-ref.yaml using file ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml
  • key metadata.json using file ci-operator/step-registry/metadata.json
• step-registry configmap in namespace ci at cluster app.ci using the following files:
  • key gather-proxy-commands.sh using file ci-operator/step-registry/gather/proxy/gather-proxy-commands.sh
  • key gather-proxy-ref.yaml using file ci-operator/step-registry/gather/proxy/gather-proxy-ref.yaml
  • key ipi-aws-post-proxy-chain.yaml using file ci-operator/step-registry/ipi/aws/post/proxy/ipi-aws-post-proxy-chain.yaml
  • key OWNERS using file ci-operator/step-registry/ipi/deprovision/proxy/OWNERS
  • key ipi-deprovision-proxy-commands.sh using file ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-commands.sh
  • key ipi-deprovision-proxy-ref.yaml using file ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml
  • key metadata.json using file ci-operator/step-registry/metadata.json

Details

In response to this:

Addresses current issue where proxy instances are being leaked due to failing to gather logs due to the proxy service not responding to ssh.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.