Switch python print statements to be python2/python3 compatible#11694
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 16, 2020
Merged
Switch python print statements to be python2/python3 compatible#11694openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
needs-rebase
eparis
force-pushed
the
python3-print
branch
from
8d860c4 to
20e435d
Compare
openshift-ci-robot
removed
the
needs-rebase
eparis
force-pushed
the
python3-print
branch
from
20e435d to
3cce3bd
Compare
wking
approved these changes
Sep 11, 2020
We use a number of `print ` statements in the repo, both in jobs and libraries. This is valid python2, but not python3. Given python2 went EOL months ago we need to catch up. This should add the header which makes python2 act like python3 in regards to print() statement and which is a noop after we switch.
eparis
force-pushed
the
python3-print
branch
from
3cce3bd to
787549f
Compare
petr-muller
approved these changes
Sep 16, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
@eparis: Updated the following 14 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Oct 22, 2020
These snuck in with 787549f (Switch python print statements to be python2/python3 compatible, 2020-09-08, openshift#11694).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use a number of
printstatements in the repo, both in jobs andlibraries. This is valid python2, but not python3. Given python2 went
EOL months ago we need to catch up.
This should add the header which makes python2 act like python3 in
regards to print() statement and which is a noop after we switch.