Skip to content

Add kubevirt-ipi workflow#12765

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
bardielle:kubevirt-ipi-workflow
Oct 20, 2020
Merged

Add kubevirt-ipi workflow#12765
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
bardielle:kubevirt-ipi-workflow

Conversation

@bardielle
Copy link
Copy Markdown
Contributor

@bardielle bardielle commented Oct 13, 2020

Signed-off-by: Roy Golan rgolan@redhat.com

@bardielle bardielle force-pushed the kubevirt-ipi-workflow branch from 6d51546 to a57080f Compare October 14, 2020 14:13
@bardielle
Copy link
Copy Markdown
Contributor Author

bardielle commented Oct 14, 2020

/test all

@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 14, 2020
@bardielle bardielle force-pushed the kubevirt-ipi-workflow branch from a57080f to 1c4db19 Compare October 14, 2020 14:22
@bardielle
Copy link
Copy Markdown
Contributor Author

bardielle commented Oct 14, 2020

/test all

@bardielle bardielle force-pushed the kubevirt-ipi-workflow branch from 1c4db19 to ce2da46 Compare October 14, 2020 14:41
@bardielle
Copy link
Copy Markdown
Contributor Author

bardielle commented Oct 14, 2020

/test all

rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/conf/kubevirt/OWNERS Outdated
Copy link
Copy Markdown
Contributor

@rgolangh rgolangh Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rgolang 👍

Copy link
Copy Markdown
Contributor

@rgolangh rgolangh Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-commands.sh Outdated
rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh Outdated
rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-chain.metadata.json Outdated
rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-ref.metadata.json Outdated
rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/kubevirt/OWNERS Outdated
Copy link
Copy Markdown
Contributor

@rgolangh rgolangh Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line + rgolang

Copy link
Copy Markdown
Contributor Author

@bardielle bardielle Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rgolang is in line 5

rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/kubevirt/ipi-kubevirt-workflow.metadata.json Outdated
rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/kubevirt/post/OWNERS Outdated
Copy link
Copy Markdown
Contributor

@rgolangh rgolangh Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line + rgolang

rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/kubevirt/post/ipi-kubevirt-post-chain.metadata.json Outdated
rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/kubevirt/post/ipi-kubevirt-post-chain.yaml Outdated
rgolangh
rgolangh reviewed Oct 14, 2020
View reviewed changes
Comment thread ci-operator/step-registry/ipi/kubevirt/pre/ipi-kubevirt-pre-chain.metadata.json Outdated
@bardielle bardielle force-pushed the kubevirt-ipi-workflow branch 3 times, most recently from 7de3cd3 to 078ebb0 Compare October 15, 2020 08:50
@rgolangh @bardielle
add kubevirt-ipi workflow
e29ec40 
Signed-off-by: Roy Golan <rgolan@redhat.com>

changing rgolang to be rgolangh
@bardielle bardielle force-pushed the kubevirt-ipi-workflow branch from 078ebb0 to e29ec40 Compare October 15, 2020 09:01
@bardielle bardielle changed the title WIP add kubevirt-ipi workflow Add kubevirt-ipi workflow Oct 19, 2020
@bardielle
Copy link
Copy Markdown
Contributor Author

bardielle commented Oct 19, 2020

/assign @staebler

@petr-muller
Copy link
Copy Markdown
Member

petr-muller commented Oct 20, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
@petr-muller
Copy link
Copy Markdown
Member

petr-muller commented Oct 20, 2020

/verify-owners

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 20, 2020
@rgolangh
Copy link
Copy Markdown
Contributor

rgolangh commented Oct 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bardielle, petr-muller, rgolangh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c77163e into openshift:master Oct 20, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 20, 2020

@bardielle: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/conf/kubevirt/OWNERS
    • key ipi-conf-kubevirt-chain.metadata.json using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-chain.metadata.json
    • key ipi-conf-kubevirt-chain.yaml using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-chain.yaml
    • key ipi-conf-kubevirt-commands.sh using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-commands.sh
    • key ipi-conf-kubevirt-ref.metadata.json using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-ref.metadata.json
    • key ipi-conf-kubevirt-ref.yaml using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-ref.yaml
    • key ipi-install-install-commands.sh using file ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh
    • key OWNERS using file ci-operator/step-registry/ipi/kubevirt/OWNERS
    • key ipi-kubevirt-workflow.metadata.json using file ci-operator/step-registry/ipi/kubevirt/ipi-kubevirt-workflow.metadata.json
    • key ipi-kubevirt-workflow.yaml using file ci-operator/step-registry/ipi/kubevirt/ipi-kubevirt-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/kubevirt/post/OWNERS
    • key ipi-kubevirt-post-chain.metadata.json using file ci-operator/step-registry/ipi/kubevirt/post/ipi-kubevirt-post-chain.metadata.json
    • key ipi-kubevirt-post-chain.yaml using file ci-operator/step-registry/ipi/kubevirt/post/ipi-kubevirt-post-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/kubevirt/pre/OWNERS
    • key ipi-kubevirt-pre-chain.metadata.json using file ci-operator/step-registry/ipi/kubevirt/pre/ipi-kubevirt-pre-chain.metadata.json
    • key ipi-kubevirt-pre-chain.yaml using file ci-operator/step-registry/ipi/kubevirt/pre/ipi-kubevirt-pre-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/kubevirt/pre/stableinitial/OWNERS
    • key ipi-kubevirt-pre-stableinitial-chain.metadata.json using file ci-operator/step-registry/ipi/kubevirt/pre/stableinitial/ipi-kubevirt-pre-stableinitial-chain.metadata.json
    • key ipi-kubevirt-pre-stableinitial-chain.yaml using file ci-operator/step-registry/ipi/kubevirt/pre/stableinitial/ipi-kubevirt-pre-stableinitial-chain.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/ipi/conf/kubevirt/OWNERS
    • key ipi-conf-kubevirt-chain.metadata.json using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-chain.metadata.json
    • key ipi-conf-kubevirt-chain.yaml using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-chain.yaml
    • key ipi-conf-kubevirt-commands.sh using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-commands.sh
    • key ipi-conf-kubevirt-ref.metadata.json using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-ref.metadata.json
    • key ipi-conf-kubevirt-ref.yaml using file ci-operator/step-registry/ipi/conf/kubevirt/ipi-conf-kubevirt-ref.yaml
    • key ipi-install-install-commands.sh using file ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh
    • key OWNERS using file ci-operator/step-registry/ipi/kubevirt/OWNERS
    • key ipi-kubevirt-workflow.metadata.json using file ci-operator/step-registry/ipi/kubevirt/ipi-kubevirt-workflow.metadata.json
    • key ipi-kubevirt-workflow.yaml using file ci-operator/step-registry/ipi/kubevirt/ipi-kubevirt-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/kubevirt/post/OWNERS
    • key ipi-kubevirt-post-chain.metadata.json using file ci-operator/step-registry/ipi/kubevirt/post/ipi-kubevirt-post-chain.metadata.json
    • key ipi-kubevirt-post-chain.yaml using file ci-operator/step-registry/ipi/kubevirt/post/ipi-kubevirt-post-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/kubevirt/pre/OWNERS
    • key ipi-kubevirt-pre-chain.metadata.json using file ci-operator/step-registry/ipi/kubevirt/pre/ipi-kubevirt-pre-chain.metadata.json
    • key ipi-kubevirt-pre-chain.yaml using file ci-operator/step-registry/ipi/kubevirt/pre/ipi-kubevirt-pre-chain.yaml
    • key OWNERS using file ci-operator/step-registry/ipi/kubevirt/pre/stableinitial/OWNERS
    • key ipi-kubevirt-pre-stableinitial-chain.metadata.json using file ci-operator/step-registry/ipi/kubevirt/pre/stableinitial/ipi-kubevirt-pre-stableinitial-chain.metadata.json
    • key ipi-kubevirt-pre-stableinitial-chain.yaml using file ci-operator/step-registry/ipi/kubevirt/pre/stableinitial/ipi-kubevirt-pre-stableinitial-chain.yaml
Details

In response to this:

Signed-off-by: Roy Golan rgolan@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chenyosef chenyosef mentioned this pull request Nov 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rgolangh rgolangh rgolangh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rgolangh rgolangh

@staebler staebler

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bardielle @petr-muller @rgolangh @openshift-ci-robot @staebler @openshift-merge-robot