Skip to content

Add aws-serial job for MCO #13435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Nov 5, 2020
Merged

Add aws-serial job for MCO #13435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...or/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ tests:
steps:
cluster_profile: aws
workflow: openshift-e2e-aws
- as: e2e-aws-serial
steps:
cluster_profile: aws
workflow: openshift-e2e-aws-serial
- as: verify
commands: |
make verify
Expand Down
63 changes: 63 additions & 0 deletions ...penshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,69 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-aws-proxy,?($|\s.*)
- agent: kubernetes
always_run: true
Copy link
Copy Markdown
Member

@wking wking Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often has the MCO broken serial tests? If this is a one-off, I'd consider always_run: false to save some CI-volume cost. This property is one that you can hand-edit in this file; it is not fed from the config YAML.

I'd also consider optional: true, to allow the MCO to merge PRs where serial tests were failing. But that's mostly to keep their throughput up if serial starts flaking out for some non-MCO reason, and if they only call in the serial tests occasionally (with an always_run: false change), requiring serial to pass or be explicitly /overriden seems reasonable too.

Copy link
Copy Markdown
Contributor

@deads2k deads2k Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often has the MCO broken serial tests? If this is a one-off, I'd consider always_run: false to save some CI-volume cost. This property is one that you can hand-edit in this file; it is not fed from the config YAML.

Everyone will say they break it infrequently. I think it's low enough in the stack to warrant it and there's an explicit scaling test where the machine-api often suspects the MCO. It came up multiple times in 4.6.

branches:
- master
cluster: build01
context: ci/prow/e2e-aws-serial
decorate: true
decoration_config:
skip_cloning: true
labels:
ci-operator.openshift.io/prowgen-controlled: "true"
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-machine-config-operator-master-e2e-aws-serial
rerun_command: /test e2e-aws-serial
spec:
containers:
- args:
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --lease-server-password-file=/etc/boskos/password
- --report-password-file=/etc/report/password.txt
- --report-username=ci
- --secret-dir=/usr/local/e2e-aws-serial-cluster-profile
- --target=e2e-aws-serial
command:
- ci-operator
image: ci-operator:latest
imagePullPolicy: Always
name: ""
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /etc/boskos
name: boskos
readOnly: true
- mountPath: /usr/local/e2e-aws-serial-cluster-profile
name: cluster-profile
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: boskos
secret:
items:
- key: password
path: password
secretName: boskos-credentials
- name: cluster-profile
projected:
sources:
- secret:
name: cluster-secrets-aws
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-aws-serial,?($|\s.*)
- agent: kubernetes
always_run: true
branches:
Expand Down