Skip to content

ci-operator/step-registry/gather/core-dump: 10m active_deadline_seconds#13600

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:timeout-for-core-gather
Nov 13, 2020
Merged

ci-operator/step-registry/gather/core-dump: 10m active_deadline_seconds#13600
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:timeout-for-core-gather

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Nov 13, 2020

Like 3c915e2 (#12647), but for the gather-core-dump step. This helps hold time to run futher gathers and tear down the cluster under test, if gather-core-dump gets hung up, like it did for over 2h here:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-update-keys/25/pull-ci-openshift-cluster-update-keys-master-e2e-aws/1326950727196610560/build-log.txt | grep -A2 'Executing pod.*gather-core-dump'
2020/11/12 20:02:15 Executing pod "e2e-aws-gather-core-dump"
2020/11/12 20:02:42 Container cp-secret-wrapper in pod e2e-aws-gather-core-dump completed successfully
{"component":"entrypoint","file":"prow/entrypoint/run.go:165","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2020-11-12T22:11:29Z"}

@wking
ci-operator/step-registry/gather/core-dump: 10m active_deadline_seconds
57ff6ab 
Like 3c915e2 (ci-operator/step-registry/openshift/e2e/test: Add 2h
active_deadline_seconds, 2020-10-09, openshift#12647), but for the
gather-core-dump step.  This helps hold time to run futher gathers and
tear down the cluster under test, if gather-core-dump gets hung up,
like it did for over 2h here [1]:

  $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-update-keys/25/pull-ci-openshift-cluster-update-keys-master-e2e-aws/1326950727196610560/build-log.txt | grep -A2 'Executing pod.*gather-core-dump'
  2020/11/12 20:02:15 Executing pod "e2e-aws-gather-core-dump"
  2020/11/12 20:02:42 Container cp-secret-wrapper in pod e2e-aws-gather-core-dump completed successfully
  {"component":"entrypoint","file":"prow/entrypoint/run.go:165","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2020-11-12T22:11:29Z"}

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-update-keys/25/pull-ci-openshift-cluster-update-keys-master-e2e-aws/1326950727196610560
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020
@wking
Copy link
Copy Markdown
Member Author

wking commented Nov 13, 2020 •
edited
Loading

I don't have stats on this step (that would be great), but here it ran successfully in under 2m.

@wking
Copy link
Copy Markdown
Member Author

wking commented Nov 13, 2020

/assign @crawford

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Nov 13, 2020 •
edited
Loading

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/cri-o/cri-o/master/e2e-aws 57ff6ab link /test pj-rehearse
ci/rehearse/openshift/cincinnati-operator/release-4.5/operator-e2e 57ff6ab link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-ovn-step-registry 57ff6ab link /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere 57ff6ab link /test pj-rehearse
ci/prow/pj-rehearse 57ff6ab link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-aws-sdn-multi 57ff6ab link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-ovn-hybrid-step-registry 57ff6ab link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crawford
Copy link
Copy Markdown
Contributor

crawford commented Nov 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford
Copy link
Copy Markdown
Contributor

crawford commented Nov 13, 2020

/test ci/build-farm/vsphere-dry

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 13, 2020

@crawford: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-dry
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-dry
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint
  • /test yamllint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-boskos-config
  • pull-ci-openshift-release-master-boskos-config-generation
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-dry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-config
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-secret-generator-config-valid
  • pull-ci-openshift-release-master-services-dry
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-yamllint
Details

In response to this:

/test ci/build-farm/vsphere-dry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford
Copy link
Copy Markdown
Contributor

crawford commented Nov 13, 2020

/test vsphere-dry

@openshift-merge-robot openshift-merge-robot merged commit 7b0c21a into openshift:master Nov 13, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 13, 2020

@wking: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key gather-core-dump-ref.yaml using file ci-operator/step-registry/gather/core-dump/gather-core-dump-ref.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key gather-core-dump-ref.yaml using file ci-operator/step-registry/gather/core-dump/gather-core-dump-ref.yaml
Details

In response to this:

Like 3c915e2 (#12647), but for the gather-core-dump step. This helps hold time to run futher gathers and tear down the cluster under test, if gather-core-dump gets hung up, like it did for over 2h here:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-update-keys/25/pull-ci-openshift-cluster-update-keys-master-e2e-aws/1326950727196610560/build-log.txt | grep -A2 'Executing pod.*gather-core-dump'
2020/11/12 20:02:15 Executing pod "e2e-aws-gather-core-dump"
2020/11/12 20:02:42 Container cp-secret-wrapper in pod e2e-aws-gather-core-dump completed successfully
{"component":"entrypoint","file":"prow/entrypoint/run.go:165","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2020-11-12T22:11:29Z"}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the timeout-for-core-gather branch November 13, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astoycos astoycos Awaiting requested review from astoycos

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

Assignees

@crawford crawford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wking @openshift-merge-robot @crawford @openshift-ci-robot