Skip to content

Add e2e-metal-assisted to machine-config-operator#14300

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
YuviGold:mco-e2e-metal-assisted
Dec 14, 2020
Merged

Add e2e-metal-assisted to machine-config-operator#14300
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
YuviGold:mco-e2e-metal-assisted

Conversation

@YuviGold
Copy link
Copy Markdown
Contributor

@YuviGold YuviGold commented Dec 13, 2020

Add an optional e2e-metal-assisted job for machine-config-operator

Generated by manually changing ci-operator/config/..., running:

$ make update

and tuning the configurable always_run and optional fields.

@YuviGold
Add e2e-metal-assisted to machine-config-operator
7b49216 
Add an optional e2e-metal-assisted job for machine-config-operator

Generated by manually changing `ci-operator/config/...`, running:

```
$ make update
```

and tuning the configurable always_run and optional fields.
cgwalters
cgwalters approved these changes Dec 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane but let's run this by the MCO team.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 14, 2020
@cgwalters cgwalters mentioned this pull request Dec 14, 2020
Merged
@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented Dec 14, 2020

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sinnykumari, YuviGold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YuviGold
Copy link
Copy Markdown
Contributor Author

YuviGold commented Dec 14, 2020

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 14, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Dec 14, 2020

@YuviGold: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-config-operator/master/e2e-azure 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-disruptive 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/cluster-bootimages 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-vsphere-upi 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-proxy 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-ovn-step-registry 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-workers-rhel7 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-metal-ipi-ovn-dualstack 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/okd-e2e-gcp-op 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-openstack 7b49216 link /test pj-rehearse
ci/prow/pj-rehearse 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-metal-assisted 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/okd-e2e-upgrade 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-agnostic-upgrade 7b49216 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-serial 7b49216 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 82eefa9 into openshift:master Dec 14, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 14, 2020

@YuviGold: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
Details

In response to this:

Add an optional e2e-metal-assisted job for machine-config-operator

Generated by manually changing ci-operator/config/..., running:

$ make update

and tuning the configurable always_run and optional fields.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@runcom runcom Awaiting requested review from runcom

1 more reviewer

@cgwalters cgwalters cgwalters approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cgwalters cgwalters

@sinnykumari sinnykumari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@YuviGold @sinnykumari @openshift-ci-robot @openshift-bot @openshift-merge-robot @cgwalters