Skip to content

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Jan 7, 2021

The conformance suite runs after disruptive events - to ensure those
don't confuse tests that check a range of time for faults, set the
new TEST_LIMIT_START_TIME variable for test execution which will
instruct those tests to look no further in the past than the start
time of the test. This will allow the disruptive and upgrade suites
to pass conformance even when they induce disruption.

openshift/origin#25784 introduced the variable for @marun to use in disruption, and #14666 will use in upgrade.

The conformance suite runs after disruptive events - to ensure those
don't confuse tests that check a range of time for faults, set the
new TEST_LIMIT_START_TIME variable for test execution which will
instruct those tests to look no further in the past than the start
time of the test. This will allow the disruptive and upgrade suites
to pass conformance even when they induce disruption.
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2021

@smarterclayton: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-api-operator/master/e2e-vsphere-operator 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi-xpn 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/aws-ebs-csi-driver-operator/release-4.5/e2e-operator 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-azure/master/e2e-upgrade 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/cincinnati-operator/release-4.5/operator-e2e 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/aws-ebs-csi-driver/master/e2e-aws-csi 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/cluster-image-registry-operator/master/e2e-vsphere 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-vsphere-ovn 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-vsphere-upi 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-proxy 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/oc/release-4.2/e2e-cmd 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-ovn-ipsec-step-registry 3a55d70 link /test pj-rehearse
ci/rehearse/cri-o/cri-o/master/e2e-gcp 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/kubernetes/master/e2e-agnostic-cmd 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-upgrade 3a55d70 link /test pj-rehearse
ci/rehearse/openshift/cluster-kube-apiserver-operator/master/e2e-aws-serial 3a55d70 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 956361f into openshift:master Jan 7, 2021
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-e2e-test-commands.sh using file ci-operator/step-registry/openshift/e2e/test/openshift-e2e-test-commands.sh
  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-e2e-test-commands.sh using file ci-operator/step-registry/openshift/e2e/test/openshift-e2e-test-commands.sh
Details

In response to this:

The conformance suite runs after disruptive events - to ensure those
don't confuse tests that check a range of time for faults, set the
new TEST_LIMIT_START_TIME variable for test execution which will
instruct those tests to look no further in the past than the start
time of the test. This will allow the disruptive and upgrade suites
to pass conformance even when they induce disruption.

openshift/origin#25784 introduced the variable for @marun to use in disruption, and #14666 will use in upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants