Skip to content

[knative-client] Add multiarch binaries to image#17351

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dsimansk:pr/kn-multiarch
Mar 31, 2021
Merged

[knative-client] Add multiarch binaries to image#17351
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dsimansk:pr/kn-multiarch

Conversation

@dsimansk
Copy link
Copy Markdown
Contributor

@dsimansk dsimansk commented Mar 31, 2021

The change is needed to have those bits present in midstream CLI artifact image.

/cc @warrenvw @rhuss

@dsimansk dsimansk mentioned this pull request Mar 31, 2021
Merged
markusthoemmes
markusthoemmes approved these changes Mar 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 31, 2021
@warrenvw
Copy link
Copy Markdown
Contributor

warrenvw commented Mar 31, 2021

/approve
/lgtm

warrenvw
warrenvw approved these changes Mar 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@warrenvw warrenvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, markusthoemmes, warrenvw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8fb4ef9 into openshift:master Mar 31, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 31, 2021

@dsimansk: Updated the ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-knative-client-release-v0.20.0.yaml using file ci-operator/config/openshift/knative-client/openshift-knative-client-release-v0.20.0.yaml
Details

In response to this:

The change is needed to have those bits present in midstream CLI artifact image.

/cc @warrenvw @rhuss

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dsimansk dsimansk deleted the pr/kn-multiarch branch April 1, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhuss rhuss Awaiting requested review from rhuss

2 more reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@warrenvw warrenvw warrenvw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@markusthoemmes markusthoemmes

@warrenvw warrenvw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dsimansk @warrenvw @openshift-ci-robot @markusthoemmes @openshift-merge-robot