Skip to content

Add chained upgrades periodics#17732

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
vrutkovs:chained-upgrades
Apr 21, 2021
Merged

Add chained upgrades periodics#17732
openshift-merge-robot merged 2 commits into
openshift:masterfrom
vrutkovs:chained-upgrades

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Apr 14, 2021

This PR updated openshift-e2e-test to support multiple update tests and adds periodic job to test 4.5 -> 4.6 -> 4.7 upgrade

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2021
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Apr 14, 2021

/retest

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Apr 14, 2021

error: Failed to acquire resource, current capacity: 0 free, 155 leased

/retest

@vrutkovs vrutkovs force-pushed the chained-upgrades branch 2 times, most recently from 009173c to 6615ccf Compare April 14, 2021 17:57
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Apr 15, 2021

/retest

@vrutkovs vrutkovs force-pushed the chained-upgrades branch 8 times, most recently from 3342ed8 to b7f1231 Compare April 15, 2021 14:02
@vrutkovs vrutkovs mentioned this pull request Apr 15, 2021
Merged
@vrutkovs vrutkovs force-pushed the chained-upgrades branch 3 times, most recently from 12a51bd to 8ecfed5 Compare April 15, 2021 18:07
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Apr 16, 2021

/retest

@vrutkovs vrutkovs changed the title WIP Add chained upgrades periodics Add chained upgrades periodics Apr 16, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2021
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Apr 20, 2021

/retest

wking
wking approved these changes Apr 20, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/17732/rehearse-17732-periodic-ci-openshift-release-master-ci-4.8-upgrade-from-stable-4.6-e2e-aws-upgrade/1384416861386444800/artifacts/e2e-aws-upgrade/gather-extra/artifacts/clusterversion.json | jq -r '.items[].status.history[] | .startedTime + " " + (.completionTime // "-") + " " + .state + " " + .version'
2021-04-20T09:54:10Z 2021-04-20T11:11:59Z Completed 4.8.0-0.ci-2021-04-19-194640
2021-04-20T08:47:27Z 2021-04-20T09:53:55Z Completed 4.7.6
2021-04-20T08:13:36Z 2021-04-20T08:42:27Z Completed 4.6.23

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Apr 21, 2021

Adding TRT for review

/cc @wking @ravisantoshgudimetla @dmage @petr-muller

@dmage
Copy link
Copy Markdown
Contributor

dmage commented Apr 21, 2021

periodic-ci-openshift-release-master-stable-4.7-upgrade-from-stable-4.5-e2e-aws-upgrade

It is implied that it goes through stable-4.6, but don't we want to have the intermediate version explicitly in the job name? Once we are able to upgrade from N to N+2, will we have both paths (4.6->4.7->4.8 and 4.6->4.8) tested?

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Apr 21, 2021

Right, good idea, renaming those

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 21, 2021

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/periodic-ci-openshift-release-master-stable-4.7-upgrade-from-stable-4.5-e2e-aws-upgrade ac2ec90108d10348686554268c2a26bf5c5e808f link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.8-upgrade-from-stable-4.6-e2e-aws-upgrade ac2ec90108d10348686554268c2a26bf5c5e808f link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-stable-4.7-upgrade-from-stable-4.6-from-stable-4.5-e2e-aws-upgrade fe7d1c5 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.8-upgrade-from-from-stable-4.7-from-stable-4.6-e2e-aws-upgrade fe7d1c5 link /test pj-rehearse
ci/prow/pj-rehearse fe7d1c5 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7301f29 into openshift:master Apr 21, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 21, 2021

@vrutkovs: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__ci-4.8-upgrade-from-from-stable-4.7-from-stable-4.6.yaml using file ci-operator/config/openshift/release/openshift-release-master__ci-4.8-upgrade-from-from-stable-4.7-from-stable-4.6.yaml
    • key openshift-release-master__stable-4.7-upgrade-from-stable-4.6-from-stable-4.5.yaml using file ci-operator/config/openshift/release/openshift-release-master__stable-4.7-upgrade-from-stable-4.6-from-stable-4.5.yaml
Details

In response to this:

This PR updated openshift-e2e-test to support multiple update tests and adds periodic job to test 4.5 -> 4.6 -> 4.7 upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droslean droslean Awaiting requested review from droslean

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

@dmage dmage Awaiting requested review from dmage

@ravisantoshgudimetla ravisantoshgudimetla Awaiting requested review from ravisantoshgudimetla

@wking wking Awaiting requested review from wking

1 more reviewer

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vrutkovs @dmage @openshift-ci-robot @wking @petr-muller @openshift-merge-robot