Skip to content

Conversation

@smarterclayton
Copy link
Contributor

Make setting PATH consistent across everyone using the TESTS image,
and fix it so that oc is copied to the installer-e2e template correctly.

Make setting PATH consistent across everyone using the TESTS image,
and fix it so that oc is copied to the installer-e2e template correctly.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2018
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

trap 'touch /tmp/shared/exit' EXIT
trap 'kill $(jobs -p); exit 0' TERM
cp "$(which oc)" /tmp/shared/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POSIX police: we had been using which before, but command -v oc is in POSIX while which is not. Obviously both will work for our test image, and we're unlikely to drop which but thought I'd point it out just in case ;).

@openshift-merge-robot openshift-merge-robot merged commit 2df6f93 into openshift:master Oct 4, 2018
@openshift-ci-robot
Copy link
Contributor

@smarterclayton: Updated the following 5 configmaps:

  • prow-job-cluster-launch-e2e-openshift-ansible configmap using the following files:
    • key cluster-launch-e2e-openshift-ansible.yaml using file ci-operator/templates/cluster-launch-e2e-openshift-ansible.yaml
  • prow-job-cluster-launch-e2e-upgrade configmap using the following files:
    • key cluster-launch-e2e-upgrade.yaml using file ci-operator/templates/cluster-launch-e2e-upgrade.yaml
  • prow-job-cluster-launch-e2e configmap using the following files:
    • key cluster-launch-e2e.yaml using file ci-operator/templates/cluster-launch-e2e.yaml
  • prow-job-cluster-launch-src configmap using the following files:
    • key cluster-launch-src.yaml using file ci-operator/templates/cluster-launch-src.yaml
  • prow-job-cluster-launch-installer-e2e configmap using the following files:
    • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Details

In response to this:

Make setting PATH consistent across everyone using the TESTS image,
and fix it so that oc is copied to the installer-e2e template correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants