-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Test path was unintentionally broken by a refactor #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test path was unintentionally broken by a refactor #1814
Conversation
Make setting PATH consistent across everyone using the TESTS image, and fix it so that oc is copied to the installer-e2e template correctly.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| trap 'touch /tmp/shared/exit' EXIT | ||
| trap 'kill $(jobs -p); exit 0' TERM | ||
| cp "$(which oc)" /tmp/shared/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
POSIX police: we had been using which before, but command -v oc is in POSIX while which is not. Obviously both will work for our test image, and we're unlikely to drop which but thought I'd point it out just in case ;).
|
@smarterclayton: Updated the following 5 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Make setting PATH consistent across everyone using the TESTS image,
and fix it so that oc is copied to the installer-e2e template correctly.