ash: Add e2e CI testing for PRs#18796
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Sep 20, 2021
Merged
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
rna-afk
force-pushed
the
e2e-ash-testing
branch
12 times, most recently
from
c5a9a30 to
8ceb676
Compare
rna-afk
force-pushed
the
e2e-ash-testing
branch
15 times, most recently
from
ac86293 to
439ed9b
Compare
Contributor
Author
|
/retest |
Contributor
|
/retest |
Comment on lines
21
to
26
Contributor
There was a problem hiding this comment.
Instead of adding this conditional, can we change the workflow to point to a different deprovision step?
Contributor
Author
There was a problem hiding this comment.
Isn't this required for the installation process too?
Contributor
There was a problem hiding this comment.
I'm not sure what you mean. Is this what you're referring to: 0f3315a#diff-65cce809dc5ddaa91711f6709acd41e5c24b735c073708e60f10aae28faf8712R65
The point I'm trying to make is that with steps we want to avoid branching or conditionality as much as possible within the steps. I think this is fine to include initially. Let's not worry about it.
Contributor
Author
|
/retest |
Contributor
|
/test pj-rehearse |
Contributor
|
/retest |
Contributor
There was a problem hiding this comment.
I don't think we want set +euE here. This is allowing execution of the script to continue after there is an error creating DNS records/zones.
Contributor
|
/retest |
Contributor
|
This is reaching tests. Awesome! 🚀 We need to add |
Contributor
|
I'm still seeing an error in the logs: It is unclear to me whether this is affecting anything? |
Contributor
Author
|
This line here checks to see if yaml exists and then installs pyyaml. So the error message is from here and I guess it won't cause problems for the later code. |
Contributor
There was a problem hiding this comment.
Due to openshift/installer#5180 we should revert this back to https://rhcossa.blob.ppe3.stackpoc.com/vhd/art-rhcos-ash.vhd
There aren't any issues with ASH, so don't worry about stopping rehearsals. Just include it in your next set of changes.
I will open a card about follow up work we can do to improve this process.
Contributor
|
/approve |
Contributor
|
@wking can you add this to your review queue? I think we will need your approval as: @openshift/test-platform can we get a review as needed by: A brief summary:
|
Contributor
|
/lgtm |
alvaroaleman
approved these changes
Sep 20, 2021
Contributor
|
/lgtm cancel |
Added steps configuration for the ASH environment to enable testing.
alvaroaleman
approved these changes
Sep 20, 2021
Contributor
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, patrickdillon, rna-afk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@rna-afk: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added steps configuration for the ASH environment to enable testing.