Skip to content

Remove image overrides from aws-ccm job and make job required#19400

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Danil-Grigorev:aws-ccm-make-optional
Jul 8, 2021
Merged

Remove image overrides from aws-ccm job and make job required#19400
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Danil-Grigorev:aws-ccm-make-optional

Conversation

@Danil-Grigorev
Copy link
Copy Markdown

@Danil-Grigorev Danil-Grigorev commented Jun 17, 2021

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@openshift-ci openshift-ci Bot requested review from JoelSpeed and lobziik June 17, 2021 20:04
@Danil-Grigorev Danil-Grigorev force-pushed the aws-ccm-make-optional branch from fd8dde6 to feec2ae Compare June 18, 2021 08:54
@JoelSpeed
Copy link
Copy Markdown
Contributor

Are we planning to merge this only post the dependent PRs merging? Not sure why we want to turn this off otherwise?

@Danil-Grigorev Danil-Grigorev force-pushed the aws-ccm-make-optional branch from feec2ae to aa51e67 Compare July 7, 2021 13:38
@Danil-Grigorev Danil-Grigorev changed the title Remove image overrides from aws-ccm job and make job optional Remove image overrides from aws-ccm job and make job required Jul 7, 2021
@Danil-Grigorev Danil-Grigorev force-pushed the aws-ccm-make-optional branch 2 times, most recently from 76bc15d to 59b132e Compare July 7, 2021 14:00
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 7, 2021

@Danil-Grigorev: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-aws-ccm 59b132ea59fee3190c3e3b5c678ed7a6c98b62c3 link /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/release-4.9/e2e-aws-ccm 59b132ea59fee3190c3e3b5c678ed7a6c98b62c3 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This will ensure the job is using unchanged cluster configuration, while migrating these clusters to CCM.
@Danil-Grigorev Danil-Grigorev force-pushed the aws-ccm-make-optional branch from 59b132e to e1b5607 Compare July 8, 2021 10:24
@Danil-Grigorev
Copy link
Copy Markdown
Author

/retest

@Danil-Grigorev
Copy link
Copy Markdown
Author

/test pj-rehearse

@Danil-Grigorev
Copy link
Copy Markdown
Author

/test all

@lobziik
Copy link
Copy Markdown
Contributor

lobziik commented Jul 8, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 42b6dc5 into openshift:master Jul 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2021

@Danil-Grigorev: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-cloud-controller-manager-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key ccm-conf-apply-feature-gate-ref.yaml using file ci-operator/step-registry/ccm/conf/apply-feature-gate/ccm-conf-apply-feature-gate-ref.yaml
    • key openshift-e2e-aws-ccm-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/ccm/openshift-e2e-aws-ccm-workflow.yaml
Details

In response to this:

This will ensure the job is using unchanged cluster configuration, while migrating these clusters to CCM.

This job will be ready to become required once all of the following PRs are merged:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants