-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix wait on router deployment for ingress operator daemonset. #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
consistency across all if conditionals would be better for readability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quotes are not required?
"${ROUTER_NAMESPACE}" has quotes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well quotes would be required if there's spaces in the actual name of the object (its router[-default] currently) I can put those in.
09148a6 to
6cf74cd
Compare
|
@abhinavdahiya made the requested changes PTAL thx |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, ramr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ramr: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Follow up based on @abhinavdahiya comments on #1952
@abhinavdahiya @crawford PTAL thx