Skip to content

Conversation

@ramr
Copy link
Contributor

@ramr ramr commented Oct 17, 2018

Follow up based on @abhinavdahiya comments on #1952

@abhinavdahiya @crawford PTAL thx

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2018
@abhinavdahiya
Copy link
Contributor

consistency across all if conditionals would be better for readability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes are not required?
"${ROUTER_NAMESPACE}" has quotes...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well quotes would be required if there's spaces in the actual name of the object (its router[-default] currently) I can put those in.

@ramr ramr force-pushed the fix-router-wait2 branch from 09148a6 to 6cf74cd Compare October 17, 2018 20:46
@ramr
Copy link
Contributor Author

ramr commented Oct 17, 2018

@abhinavdahiya made the requested changes PTAL thx

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2018
@openshift-merge-robot openshift-merge-robot merged commit 7f37a6d into openshift:master Oct 17, 2018
@openshift-ci-robot
Copy link
Contributor

@ramr: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Details

In response to this:

Follow up based on @abhinavdahiya comments on #1952

@abhinavdahiya @crawford PTAL thx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramr ramr deleted the fix-router-wait2 branch October 23, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants