Skip to content

Conversation

@lranjbar
Copy link
Contributor

@lranjbar lranjbar commented Jul 7, 2021

Promotes the built images in prow to the CI registry. This will allow us to use the images that are built from the ocm-2.3 branch in our jobs. Currently the jobs are using the images built from master. However, the master and ocm-2.3 branch have diverged creating some failures in the jobs due to version mismatch.

@openshift-ci openshift-ci bot requested review from carbonin and osherdp July 7, 2021 14:08
@carbonin
Copy link
Member

carbonin commented Jul 7, 2021

@lranjbar can you give some information in the PR and commit about what this does and why we're doing it?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2021

@lranjbar: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/assisted-service/ocm-2.3/lint 1a833f8 link /test pj-rehearse
ci/rehearse/openshift/assisted-service/ocm-2.3/subsystem-kubeapi-aws 1a833f8 link /test pj-rehearse
ci/rehearse/openshift/assisted-service/ocm-2.3/subsystem-aws 1a833f8 link /test pj-rehearse
ci/rehearse/openshift/assisted-installer/ocm-2.3/e2e-metal-assisted 1a833f8 link /test pj-rehearse
ci/rehearse/openshift/assisted-installer-agent/ocm-2.3/e2e-metal-assisted 1a833f8 link /test pj-rehearse
ci/rehearse/openshift/assisted-service/ocm-2.3/e2e-metal-assisted-operator-ztp 1a833f8 link /test pj-rehearse
ci/rehearse/openshift/assisted-installer-agent/ocm-2.3/lint 1a833f8 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@osherdp
Copy link
Contributor

osherdp commented Jul 7, 2021

/hold
unhold whenever you want, I think only PR description is missing here

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lranjbar, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@lranjbar
Copy link
Contributor Author

lranjbar commented Jul 7, 2021

@lranjbar can you give some information in the PR and commit about what this does and why we're doing it?

Yeah for sure. I was hoping I didn't have to split this off #19925 😄

@lranjbar
Copy link
Contributor Author

lranjbar commented Jul 7, 2021

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3eaa74d into openshift:master Jul 7, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2021

@lranjbar: Updated the ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-assisted-installer-agent-ocm-2.3.yaml using file ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-ocm-2.3.yaml
  • key openshift-assisted-installer-ocm-2.3.yaml using file ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-ocm-2.3.yaml
  • key openshift-assisted-service-ocm-2.3.yaml using file ci-operator/config/openshift/assisted-service/openshift-assisted-service-ocm-2.3.yaml
Details

In response to this:

Promotes the built images in prow to the CI registry. This will allow us to use the images that are built from the ocm-2.3 branch in our jobs. Currently the jobs are using the images built from master. However, the master and ocm-2.3 branch have diverged creating some failures in the jobs due to version mismatch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lranjbar lranjbar deleted the assisted-image-promotion-enabled branch January 27, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants