Make sure TPNU or CustomNoUpgrade FG does not affect test results#20701
Conversation
|
Just FYI, I'm trying to fix this long term with openshift/origin#26349 |
|
@JoelSpeed There will be providers using CustomNoUpgrade for a while. But for TP, sure, cool. |
elmiko
left a comment
There was a problem hiding this comment.
the test failures seem unrelated
/lgtm
Either TPNU or CustomNoUpgrade results in alerts firing in e2e tests, however it is expected in CCM use-case and should not make the test fail. - `Managed cluster should start all core operators` - kube-api-server operator has a specific alert, notifying the cluster is non-upgradable with TP or CNU featureGates. This outputs: ``` Upgradeable=False FeatureGates_RestrictedFeatureGates_CustomNoUpgrade: FeatureGatesUpgradeable: "CustomNoUpgrade" does not allow updates ``` marking operator non-healthy in e2e tests. This is not critical and is expected in successfull job pass.
1e93c56 to
2d81ab8
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Danil-Grigorev, elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Danil-Grigorev: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Either TPNU or CustomNoUpgrade results in alerts firing in e2e tests,
however it is expected in CCM use-case and should not make the test fail.
Managed cluster should start all core operators- kube-api-server operatorhas a specific alert, notifying the cluster is non-upgradable with TP or CNU
featureGates. This outputs:
marking operator non-healthy in e2e tests. This is not critical and
is expected in successfull job pass.