Skip to content

Make sure TPNU or CustomNoUpgrade FG does not affect test results#20701

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Danil-Grigorev:test-skips-os-azure-ccm
Jul 29, 2021
Merged

Make sure TPNU or CustomNoUpgrade FG does not affect test results#20701
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Danil-Grigorev:test-skips-os-azure-ccm

Conversation

@Danil-Grigorev
Copy link
Copy Markdown

Either TPNU or CustomNoUpgrade results in alerts firing in e2e tests,
however it is expected in CCM use-case and should not make the test fail.

  • Managed cluster should start all core operators - kube-api-server operator
    has a specific alert, notifying the cluster is non-upgradable with TP or CNU
    featureGates. This outputs:
Upgradeable=False FeatureGates_RestrictedFeatureGates_CustomNoUpgrade: FeatureGatesUpgradeable: "CustomNoUpgrade" does not allow updates

marking operator non-healthy in e2e tests. This is not critical and
is expected in successfull job pass.

@openshift-ci openshift-ci Bot requested review from EmilienM and elmiko July 29, 2021 15:19
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@JoelSpeed
Copy link
Copy Markdown
Contributor

Just FYI, I'm trying to fix this long term with openshift/origin#26349

@Danil-Grigorev
Copy link
Copy Markdown
Author

@JoelSpeed There will be providers using CustomNoUpgrade for a while. But for TP, sure, cool.

Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test failures seem unrelated
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
Either TPNU or CustomNoUpgrade results in alerts firing in e2e tests,
however it is expected in CCM use-case and should not make the test fail.

- `Managed cluster should start all core operators` - kube-api-server operator
has a specific alert, notifying the cluster is non-upgradable with TP or CNU
featureGates. This outputs:

```
Upgradeable=False FeatureGates_RestrictedFeatureGates_CustomNoUpgrade: FeatureGatesUpgradeable: "CustomNoUpgrade" does not allow updates
```

marking operator non-healthy in e2e tests. This is not critical and
is expected in successfull job pass.
@Danil-Grigorev Danil-Grigorev force-pushed the test-skips-os-azure-ccm branch from 1e93c56 to 2d81ab8 Compare July 29, 2021 15:37
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 38f3336 into openshift:master Jul 29, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 29, 2021

@Danil-Grigorev: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-e2e-aws-ccm-install-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/ccm/install/openshift-e2e-aws-ccm-install-workflow.yaml
  • key openshift-e2e-azure-ccm-install-workflow.yaml using file ci-operator/step-registry/openshift/e2e/azure/ccm/install/openshift-e2e-azure-ccm-install-workflow.yaml
  • key openshift-e2e-azure-ccm-workflow.yaml using file ci-operator/step-registry/openshift/e2e/azure/ccm/openshift-e2e-azure-ccm-workflow.yaml
  • key openshift-e2e-openstack-ccm-workflow.yaml using file ci-operator/step-registry/openshift/e2e/openstack/ccm/openshift-e2e-openstack-ccm-workflow.yaml
Details

In response to this:

Either TPNU or CustomNoUpgrade results in alerts firing in e2e tests,
however it is expected in CCM use-case and should not make the test fail.

  • Managed cluster should start all core operators - kube-api-server operator
    has a specific alert, notifying the cluster is non-upgradable with TP or CNU
    featureGates. This outputs:
Upgradeable=False FeatureGates_RestrictedFeatureGates_CustomNoUpgrade: FeatureGatesUpgradeable: "CustomNoUpgrade" does not allow updates

marking operator non-healthy in e2e tests. This is not critical and
is expected in successfull job pass.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants