Bug 1991730: fixing aws zones mismatch issue

[jianlinliu]

In https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-proxy/1415490000736227328, get this error:

level=fatal msg=failed to fetch Master Machines: failed to load asset "Install Config": [controlPlane.platform.aws.zones: Invalid value: []string{"us-east-1f", "us-east-1a"}: No subnets provided for zones [us-east-1f], compute[0].platform.aws.zones: Invalid value: []string{"us-east-1f", "us-east-1a"}: No subnets provided for zones [us-east-1f]]

That is because in ./ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh, it randomly selected "us-east-1f", "us-east-1a" as test target zones, but in the following ./ci-operator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh, it is using vpc cf to create subnets, while the cf is creating subnets for zones in order, e.g: when AvailabilityZoneCount = 2, the cf will select the top 2 zones to create subnets, that means it is not random, that lead to no subnets created for "us-east-1f", so the error is thrown out.

This PR is fixing that issue

Also this will resolve the following issues:
https://issues.redhat.com/browse/CORS-1730
https://bugzilla.redhat.com/show_bug.cgi?id=1991730

[openshift-ci]

@jianlinliu: This pull request references Bugzilla bug 1991730, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1991730: fixing zones mismatch issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jianlinliu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/origin/release-4.1/e2e-aws-image-ecosystem	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/origin/release-4.1/e2e-aws-builds	f85d035	link	/test pj-rehearse
ci/rehearse/redhat-developer/jenkins-operator/main/e2e	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/cluster-logging-operator/tech-preview/e2e-operator	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/aws-efs-csi-driver-operator/release-4.9/operator-e2e	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/sdn/release-4.9/e2e-aws-multitenant	f85d035	link	/test pj-rehearse
ci/rehearse/red-hat-storage/odf-operator/main/odf-operator-bundle-e2e-aws	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/origin/release-4.2/e2e-cmd	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/machine-config-operator/release-4.9/e2e-aws-techpreview-featuregate	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/builder/release-4.9/e2e-aws-cgroupsv2	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/release-4.9/e2e-aws-manual-oidc	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/kubernetes/release-4.9/k8s-e2e-aws-serial	f85d035	link	/test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-single-node	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/kubernetes/release-4.9/configmap-scale	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.9/e2e-ovn-ipsec-step-registry	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/release-4.9/e2e-aws-ccm-install	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/ovn-kubernetes/release-4.9/e2e-ovn-hybrid-step-registry	f85d035	link	/test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-stable-4.8-upgrade-from-stable-4.6-e2e-aws-upgrade-paused	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/installer/release-4.9/e2e-aws-upgrade	f85d035	link	/test pj-rehearse
ci/rehearse/openshift/origin/release-4.9/e2e-aws-disruptive	f85d035	link	/test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.9-e2e-aws-upgrade-single-node	f85d035	link	/test pj-rehearse
ci/prow/pj-rehearse	f85d035	link	/test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[bparees]

/lgtm

[jianlinliu]

/assign @vrutkovs

[vrutkovs]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jianlinliu, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/ipi/OWNERS [vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jianlinliu: All pull requests linked via external trackers have merged:

• openshift/release#21145

Bugzilla bug 1991730 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1991730: fixing aws zones mismatch issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@jianlinliu: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

• key ipi-conf-aws-blackholenetwork-chain.yaml using file ci-operator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-chain.yaml
• key ipi-conf-aws-blackholenetwork-commands.sh using file ci-operator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh
• key ipi-conf-aws-blackholenetwork-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-ref.yaml
• key ipi-conf-aws-commands.sh using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh
• key ipi-conf-aws-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-ref.yaml
• key ipi-conf-aws-proxy-commands.sh using file ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-commands.sh
• key ipi-conf-aws-sharednetwork-chain.yaml using file ci-operator/step-registry/ipi/conf/aws/sharednetwork/ipi-conf-aws-sharednetwork-chain.yaml
• key ipi-conf-aws-sharednetwork-commands.sh using file ci-operator/step-registry/ipi/conf/aws/sharednetwork/ipi-conf-aws-sharednetwork-commands.sh
• key ipi-conf-aws-sharednetwork-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/sharednetwork/ipi-conf-aws-sharednetwork-ref.yaml

Details

In response to this:

In https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.9-e2e-aws-proxy/1415490000736227328, get this error:

level=fatal msg=failed to fetch Master Machines: failed to load asset "Install Config": [controlPlane.platform.aws.zones: Invalid value: []string{"us-east-1f", "us-east-1a"}: No subnets provided for zones [us-east-1f], compute[0].platform.aws.zones: Invalid value: []string{"us-east-1f", "us-east-1a"}: No subnets provided for zones [us-east-1f]]

That is because in ./ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh, it randomly selected "us-east-1f", "us-east-1a" as test target zones, but in the following ./ci-operator/step-registry/ipi/conf/aws/blackholenetwork/ipi-conf-aws-blackholenetwork-commands.sh, it is using vpc cf to create subnets, while the cf is creating subnets for zones in order, e.g: when AvailabilityZoneCount = 2, the cf will select the top 2 zones to create subnets, that means it is not random, that lead to no subnets created for "us-east-1f", so the error is thrown out.

This PR is fixing that issue

Also this will resolve the following issues:
https://issues.redhat.com/browse/CORS-1730
https://bugzilla.redhat.com/show_bug.cgi?id=1991730

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.