Skip to content

[knative-client] Add CI setup for release v0.25.1#22387

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
dsimansk:pr/knative-client-v0.25.1
Oct 1, 2021
Merged

[knative-client] Add CI setup for release v0.25.1#22387
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
dsimansk:pr/knative-client-v0.25.1

Conversation

@dsimansk
Copy link
Copy Markdown
Contributor

@dsimansk dsimansk commented Sep 30, 2021

Per title.

/cc @rhuss @vyasgun

@openshift-ci openshift-ci bot requested review from rhuss and vyasgun September 30, 2021 11:59
@dsimansk
Copy link
Copy Markdown
Contributor Author

dsimansk commented Sep 30, 2021

/retest

@dsimansk
Copy link
Copy Markdown
Contributor Author

dsimansk commented Oct 1, 2021

/test all

@dsimansk dsimansk mentioned this pull request Oct 1, 2021
Merged
vyasgun
vyasgun reviewed Oct 1, 2021
View reviewed changes
Copy link
Copy Markdown

@vyasgun vyasgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2021
@dsimansk
Copy link
Copy Markdown
Contributor Author

dsimansk commented Oct 1, 2021

Since the PR is touching image mirroring, could you please take a look? To have client updated sooner then few days before cut. :)

@markusthoemmes @matzew

rhuss
rhuss reviewed Oct 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit a0d4043 into openshift:master Oct 1, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Oct 1, 2021

@dsimansk: Updated the following 3 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-client-release-v0.25.1.yaml using file ci-operator/config/openshift/knative-client/openshift-knative-client-release-v0.25.1.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-knative-client-release-v0.25.1-postsubmits.yaml using file ci-operator/jobs/openshift/knative-client/openshift-knative-client-release-v0.25.1-postsubmits.yaml
    • key openshift-knative-client-release-v0.25.1-presubmits.yaml using file ci-operator/jobs/openshift/knative-client/openshift-knative-client-release-v0.25.1-presubmits.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_knative_v0_25_quay using file core-services/image-mirroring/knative/mapping_knative_v0_25_quay
Details

In response to this:

Per title.

/cc @rhuss @vyasgun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rhuss rhuss rhuss left review comments

@vyasgun vyasgun vyasgun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rhuss rhuss

@vyasgun vyasgun

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dsimansk @rhuss @vyasgun @openshift-merge-robot