OWNERS_ALIASES: Remove no-longer-auto-maintained cruft #22476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prunes aliases that used to be maintained automatically. The tooling that used to maintain them was removed in 58d12ef (Clean up deprecated tool: populate-owners, 2019-09-19, openshift#5115), and the tooling that replaced it will not pick up that missing functionality [1,2]. This commit removes the stale "auto-generated" comment, and also all unused aliases: $ diff -u <(yaml2json <OWNERS_ALIASES | jq -r '.aliases | keys[]' | sort) <(find . -name OWNERS -exec grep -h "$(yaml2json <OWNERS_ALIASES | jq -r '.aliases | keys | join("\\|")')" {} \+ | sed -n 's/^ *- //p' | sort | uniq) | grep '^-' [1]: openshift/ci-tools#115 (comment) [2]: https://issues.redhat.com/browse/DPTP-690
The list was quite stale. Now that there's no longer a chance of auto-generated updates, manually update it to match [1] (but with a case-insensitive alphabetical sort). [1]: https://github.com/openshift/cincinnati/blob/bd11660e7279e03e105eff64eef5fd13bdc96984/OWNERS_ALIASES#L4-L10
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: emilvberglind, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prunes aliases that used to be maintained automatically. The tooling that used to maintain them was removed in 58d12ef (#5115), and the tooling that replaced it will not pick up that missing functionality. This commit removes the stale "auto-generated" comment, and also all unused aliases:
$ diff -u <(yaml2json <OWNERS_ALIASES | jq -r '.aliases | keys[]' | sort) <(find . -name OWNERS -exec grep -h "$(yaml2json <OWNERS_ALIASES | jq -r '.aliases | keys | join("\\|")')" {} \+ | sed -n 's/^ *- //p' | sort | uniq) | grep '^-'Also updates
cincinnati-approversby hand to match the current config (but with a case-insensitive, alphabetical sort).