Skip to content

Machine API: Remove generate check#23054

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
alexander-demicev:mapigenerate
Oct 27, 2021
Merged

Machine API: Remove generate check#23054
openshift-merge-robot merged 1 commit into
openshift:masterfrom
alexander-demicev:mapigenerate

Conversation

@alexander-demicev
Copy link
Copy Markdown
Contributor

All generated code is being moved from machine api operator to openshift api repo. This task is not needed anymore.
openshift/machine-api-operator#943

@lobziik
Copy link
Copy Markdown
Contributor

lobziik commented Oct 27, 2021

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev, lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
@openshift-ci openshift-ci Bot requested review from JoelSpeed and elmiko October 27, 2021 11:04
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit c36dda8 into openshift:master Oct 27, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 27, 2021

@alexander-demichev: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-api-operator-master.yaml using file ci-operator/config/openshift/machine-api-operator/openshift-machine-api-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-machine-api-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-master-presubmits.yaml
Details

In response to this:

All generated code is being moved from machine api operator to openshift api repo. This task is not needed anymore.
openshift/machine-api-operator#943

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants